chore: drop CHROMIUM_BUILDTOOLS_PATH in favor of a buildtools symlink#855
Open
codebytere wants to merge 1 commit intomainfrom
Open
chore: drop CHROMIUM_BUILDTOOLS_PATH in favor of a buildtools symlink#855codebytere wants to merge 1 commit intomainfrom
codebytere wants to merge 1 commit intomainfrom
Conversation
codebytere
changed the title
depot_tools added a stderr warning in CL:7790518
("gn: print if CHROMIUM_BUILDTOOLS_PATH is used") declaring the env
var "highly unsupported and may break gn."
We were setting it because Electron's gclient solution is named
`src/electron`, so depot_tools' auto-detection looks for buildtools
at `<root>/src/electron/buildtools` and `<root>/buildtools` — neither
exists in our layout (the real dir is `<root>/src/buildtools`).
Add ensureBuildtoolsSymlink() that creates `<root>/buildtools` ->
`src/buildtools` (dir symlink on POSIX, junction on Windows). That
satisfies depot_tools' supported `<gclient_root>/buildtools` lookup
and lets us drop the env var entirely.
Wire the helper into `e init`, `e sync`, `e worktree add`, and
sanitizeConfig so new and existing checkouts are migrated
transparently. sanitizeConfig also strips CHROMIUM_BUILDTOOLS_PATH
from saved configs on load. The schema keeps it as an optional field
for backwards compatibility but no longer requires it.
codebytere
force-pushed
the
drop-chromium-buildtools-path
branch
from
4e57cdf to
dfb9ea7
Compare
jkleinsc
requested changes
Apr 30, 2026
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
Looks like this change is causing a failure on Windows
This was referenced May 1, 2026
dsanders11
requested changes
May 2, 2026
Member
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
Leaving this open for now in case it doesn't work out, but I think #859 is the approach we want to take to ensure maximum compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depot_tools added a stderr warning in CL:7790518 declaring the env var "highly unsupported and may break gn."
We were setting it because Electron's gclient solution is named
src/electron, so depot_tools' auto-detection looks for buildtools at<root>/src/electron/buildtoolsand<root>/buildtools— neither exists in our layout (the real dir is<root>/src/buildtools).Add ensureBuildtoolsSymlink() that creates
<root>/buildtools->src/buildtools(dir symlink on POSIX, junction on Windows). That satisfies depot_tools' supported<gclient_root>/buildtoolslookup and lets us drop the env var entirely.Wire the helper into
e init,e sync,e worktree add, and sanitizeConfig so new and existing checkouts are migrated transparently. sanitizeConfig also strips CHROMIUM_BUILDTOOLS_PATH from saved configs on load. The schema keeps it as an optional field for backwards compatibility but no longer requires it.