build: create a symlink to src/buildtools during sync#51440
Draft
dsanders11 wants to merge 3 commits intomainfrom
Draft
build: create a symlink to src/buildtools during sync#51440dsanders11 wants to merge 3 commits intomainfrom
dsanders11 wants to merge 3 commits intomainfrom
Conversation
3c471be to
8251866
Compare
0c7f3d4 to
a4da6a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We use
CHROMIUM_BUILDTOOLS_PATHpretty aggressively, but recent upstream changes have made it clear that they consider it "highly unsupported" so we need to switch to a better method.@codebytere put up electron/build-tools#855, and I agree with the general approach that symlinking it is the cleanest solution we have to work with
depot_tools/gclient_paths.py. However, that PR would only work for folks usingbuild-tools, and we also need to support folks who are building withoutbuild-toolsand bring their owndepot_tools.This PR puts the symlink creation in as part of the sync process, so it will always exist whether you're building with
build-toolsor not. I'll follow up with a PR forbuild-toolsto detect if the symlink exists and matchesCHROMIUM_BUILDTOOLS_PATH, and if so not set the environment variable, otherwise continue to set it for backwards compatibility. After enough time has passed that we're confident all supported builds are using the changes in this PR, we can rip outCHROMIUM_BUILDTOOLS_PATHfrombuild-toolsas well.Checklist
Release Notes
Notes: none