Skip to content

fix: correct the drawing-game Socket.IO version labels #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wufangyong973 wants to merge 1 commit into from
Closed

fix: correct the drawing-game Socket.IO version labels #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/drawing-game/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ pnpm example:drawing-game:dev:real
```

Follow the same A/B/C actions. The target badge reads `REAL · SOCKET.IO`. Vite's
Node HTTP server now also hosts a real `socket.io@4.8.3` server, and the pages
connect with `socket.io-client@4.8.3`. The application handler, event types,
Node HTTP server now also hosts a real `socket.io@4.8.4` server, and the pages
connect with `socket.io-client@4.8.4`. The application handler, event types,
state rules, React UI, and user actions do not change.

## Source map
Expand Down
2 changes: 1 addition & 1 deletion examples/drawing-game/observe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ console.log(
{
schemaVersion: 1,
targets: {
'socket.io@4.8.3': socketIoObservation,
'socket.io@4.8.4': socketIoObservation,
'smocket@workspace': smocketObservation,
},
deeplyEqual: true,
Expand Down
Loading