docs: require merged PR before tagging a release - #54
Merged
Conversation
npm version patch + git push origin --tags let a version bump commit get tagged and released without ever landing on the protected main branch, orphaning the tag (this happened with v1.0.4 and v1.0.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm version patch+git push origin --tags) only pushes the tag, not the commit — sincemainis protected and requires a PR, the version-bump commit never actually lands onmain.main's history, which in turn causednpm version patchto recompute from a stale version and collide with an already-released tag.main's resulting commit.