Skip to content

Feature/dotprompt sql upgrade #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azurecoder merged 3 commits into from
Apr 6, 2026
Merged

Feature/dotprompt sql upgrade #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22958f
Restore workflow_dispatch to release workflow with version input
azurecoder Apr 6, 2026
7fc507b
Upgrade all projects and workflows to .NET 10
azurecoder Apr 6, 2026
4f3fffb
Update readme: add .NET 10 requirement
azurecoder Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 9.0.x
dotnet-version: 10.0.x
- name: Restore dependencies
run: dotnet restore
- name: Build
Expand Down
16 changes: 13 additions & 3 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ on:
push:
tags:
- 'v*'
workflow_dispatch:
inputs:
version:
description: 'Package version (e.g. 0.2.3)'
required: true

jobs:
build:
Expand All @@ -16,10 +21,15 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 9.0.x
- name: Get version from tag
dotnet-version: 10.0.x
- name: Get version from tag or input
id: vars
run: echo "RELEASE_VERSION=${GITHUB_REF_NAME#v}" >> $GITHUB_ENV
run: |
if [ -n "${{ github.event.inputs.version }}" ]; then
echo "RELEASE_VERSION=${{ github.event.inputs.version }}" >> $GITHUB_ENV
else
echo "RELEASE_VERSION=${GITHUB_REF_NAME#v}" >> $GITHUB_ENV
fi
- name: Package
run: |
echo "Release version: $RELEASE_VERSION"
Expand Down
2 changes: 1 addition & 1 deletion DotPrompt.Sql.Cli/DotPrompt.Sql.Cli.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
2 changes: 1 addition & 1 deletion DotPrompt.Sql.Test/DotPrompt.Sql.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand Down
2 changes: 1 addition & 1 deletion DotPrompt.Sql/DotPrompt.Sql.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PackageId>DotPrompt.Sql</PackageId>
Expand Down
5 changes: 5 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ A SQL store for the [DotPrompt](https://github.com/elastacloud/dotprompt) librar

A CLI is provided to add prompt files directly to the database.

## Requirements

- .NET 10
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README now states the repo requires .NET 10, but global.json still pins the SDK to 9.0.0 (with rollForward). This creates a confusing/dev-breaking mismatch (e.g., a developer with only .NET 9 installed will follow global.json and then fail to build net10.0 projects). Consider updating global.json to a .NET 10 SDK version (or adjusting the README/TFM if .NET 10 is not intended yet) so the documented requirement and repo tooling agree.

Suggested change
- .NET 10
- .NET SDK version specified in `global.json`

Copilot uses AI. Check for mistakes.
- SQL Server, Azure SQL DB, or Microsoft Fabric SQL DB

## Installation

```
Expand Down
Loading