Feature/dotprompt sql upgrade#9
Conversation
Adds back the manual 'Run workflow' button with a required version input (e.g. 0.2.3). Tag-triggered runs still derive the version from the tag automatically. Both paths set RELEASE_VERSION before pack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- DotPrompt.Sql, DotPrompt.Sql.Cli, DotPrompt.Sql.Test: net9.0 -> net10.0 - dotnet.yml and release.yaml: dotnet-version 9.0.x -> 10.0.x Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository to target .NET 10 and aligns GitHub Actions workflows with the new SDK version, while documenting the new runtime requirement.
Changes:
- Upgrade all projects from
net9.0tonet10.0. - Update CI and release workflows to install .NET
10.0.x. - Document .NET 10 and supported SQL backends in the README.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
readme.md |
Adds a “Requirements” section including .NET 10 and supported SQL platforms. |
DotPrompt.Sql/DotPrompt.Sql.csproj |
Targets net10.0 for the main library package. |
DotPrompt.Sql.Test/DotPrompt.Sql.Test.csproj |
Targets net10.0 for the test project. |
DotPrompt.Sql.Cli/DotPrompt.Sql.Cli.csproj |
Targets net10.0 for the CLI project. |
.github/workflows/release.yaml |
Uses .NET 10 and allows manual release version input via workflow_dispatch. |
.github/workflows/dotnet.yml |
Uses .NET 10 in build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## Requirements | ||
|
|
||
| - .NET 10 |
There was a problem hiding this comment.
README now states the repo requires .NET 10, but global.json still pins the SDK to 9.0.0 (with rollForward). This creates a confusing/dev-breaking mismatch (e.g., a developer with only .NET 9 installed will follow global.json and then fail to build net10.0 projects). Consider updating global.json to a .NET 10 SDK version (or adjusting the README/TFM if .NET 10 is not intended yet) so the documented requirement and repo tooling agree.
| - .NET 10 | |
| - .NET SDK version specified in `global.json` |
No description provided.