3D Ball-Linear-Cushion Detection

[derek-mcblane]

Adding 3D detection support for ball-linear-cushion to resolve #303.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c9c6b4d-b746-4df8-8ff0-8cfd9d5dd640

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[derek-mcblane]

• Still need to limit detections to the length of the cushion segment

[codecov]

Codecov Report

❌ Patch coverage is 73.29193% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.71%. Comparing base (0b344e7) to head (65bb7c0).

Files with missing lines	Patch %	Lines
pooltool/ptmath/roots/core.py	13.79%	25 Missing ⚠️
...ltool/evolution/event_based/detect/ball_cushion.py	77.41%	7 Missing ⚠️
pooltool/physics/resolve/ball_cushion/core.py	87.50%	6 Missing ⚠️
...olution/event_based/detect/quartic_coefficients.py	28.57%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   47.75%   47.71%   -0.04%     
==========================================
  Files         159      159              
  Lines       10716    10796      +80     
==========================================
+ Hits         5117     5151      +34     
- Misses       5599     5645      +46     

Flag	Coverage Δ
service	47.71% <73.29%> (-0.04%)	⬇️
service-no-ani	57.95% <73.29%> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.