3D Ball-Linear-Cushion Resolution

[derek-mcblane]

Still very much a draft. Waiting on #350.

No issue for this one yet, I think we're waiting on #310.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eb990480-e326-4e17-889f-30bef59bd37d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 70.38462% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.73%. Comparing base (96020df) to head (3e9976f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pooltool/ptmath/roots/core.py	13.79%	25 Missing ⚠️
...ion/event_based/detect/ball_position_polynomial.py	34.78%	15 Missing ⚠️
...olution/event_based/detect/quartic_coefficients.py	40.00%	12 Missing ⚠️
...ball_cushion/impulse_frictional_inelastic/model.py	68.57%	11 Missing ⚠️
...ltool/evolution/event_based/detect/ball_cushion.py	77.41%	7 Missing ⚠️
pooltool/physics/resolve/ball_cushion/core.py	87.50%	6 Missing ⚠️
pooltool/evolution/event_based/detect/ball_ball.py	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   47.69%   47.73%   +0.03%     
==========================================
  Files         157      159       +2     
  Lines       10665    10821     +156     
==========================================
+ Hits         5087     5165      +78     
- Misses       5578     5656      +78     

Flag	Coverage Δ
service	47.73% <70.38%> (+0.03%)	⬆️
service-no-ani	57.95% <70.38%> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[derek-mcblane]

Going to wait for issue. Will do #309 first.