Skip to content

fix(query): keep tag-aware guard on projectComputed only #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omegent-app merged 1 commit into from
Aug 4, 2026
Merged

fix(query): keep tag-aware guard on projectComputed only #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/projectable-key-guard-project.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"effect-app": patch
"@effect-app/infra": patch
"@effect-app/vue": patch
"@effect-app/vue-components": patch
---

Keep tag-aware `ProjectableFromDomain` for `projectComputed` only; restore loose key-presence guard for `project()` so view DTOs with reshaped fields keep typechecking.
16 changes: 13 additions & 3 deletions packages/effect-app/src/Model/query/dsl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,16 @@ export type ProjectableFromDomain<
ExtraKeys extends PropertyKey = never
> = ProjectableGuard<ProjectionEncoded, DomainEncoded, ExtraKeys>

/**
* Loose key-presence guard for {@link project}: every projection key must exist
* on *some* domain member (`KeysOfUnion`). Does **not** enforce per-tag
* ownership — views may reshape freely. Use {@link ProjectableFromDomain} /
* `projectComputed` when tag-scoped ownership matters.
*/
type ProjectableKeyGuard<I, From> = [I] extends [FieldValues]
? (Exclude<keyof I, KeysOfUnion<From> | "_tag"> extends never ? unknown : never)
: unknown

export type RelationDirection = "some" | "every"
export type Relation = { relation: RelationDirection }
export type Query<TFieldValues extends FieldValues> = QueryTogether<TFieldValues, TFieldValues>
Expand Down Expand Up @@ -606,7 +616,7 @@ export const project: {
>(
schema:
& S.Codec<Option.Option<A>, I, R>
& ProjectableGuard<I, ExtractFieldValues<Q>>,
& ProjectableKeyGuard<I, ExtractFieldValues<Q>>,
mode: "collect"
): (
current: Q
Expand All @@ -621,7 +631,7 @@ export const project: {
>(
schema:
& S.Codec<A, I, R>
& ProjectableGuard<I, ExtractFieldValues<Q>>,
& ProjectableKeyGuard<I, ExtractFieldValues<Q>>,
mode: "project"
): (
current: Q
Expand All @@ -635,7 +645,7 @@ export const project: {
>(
schema:
& S.Codec<A, I, R>
& ProjectableGuard<I, ExtractFieldValues<Q>>
& ProjectableKeyGuard<I, ExtractFieldValues<Q>>
): (
current: Q
) => QueryProjection<ExtractFieldValuesRefined<Q>, A, R, ExtractTType<Q>, E>
Expand Down
Loading