fix(query): keep tag-aware guard on projectComputed only - #847
Merged
Conversation
`project()` is used for view DTOs that intentionally reshape domain fields. Tag-scoped ProjectableFromDomain stays on projectComputed (overview path). Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
4.0.0-beta.306applied tag-awareProjectableFromDomainto bothprojectandprojectComputed.project()is widely used for view DTOs that reshape domain fields (toEncoded(ViewUnion), extra view-only keys, narrowed package views). That broke typecheck in macs-scanner on bump.What
project()uses a looseProjectableKeyGuard(key present on some domain member).projectComputedkeeps tag-awareProjectableFromDomain(the MACS-SCANNER-API-KS guard).Remarks
Follow-up to #845 / #846.
Co-authored-by: @patroza
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.