[GEF] Harmonize getTargetEditPart(...) in EditPart with upstream class#1413
Open
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Open
[GEF] Harmonize getTargetEditPart(...) in EditPart with upstream class#1413ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
ptziegler
force-pushed
the
gef-edit-part-target-ep
branch
3 times, most recently
from
eef5f5f to
1bc0c9e
Compare
This is a continuation of 1be791a. The `getTargetEditPart(Request)` method inside an `EditPart` should not check whether its `EditPolicy` understands the request; This should instead be done by the edit policies themselves.
ptziegler
force-pushed
the
gef-edit-part-target-ep
branch
from
1bc0c9e to
8fc73ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of 1be791a. The
getTargetEditPart(Request)method inside anEditPartshould not check whether itsEditPolicyunderstands the request; This should instead be done by the edit policies themselves.