Repository navigation
Apply the trail-maps waypoint QC: remove a private email, fix names, macrons and closures - #11
Merged
Merged
Conversation
The trust's KMZ gives Makene Road Campsite a phone field that holds a personal email address. The build passed it straight through, so it was in both GPX files, both resupply plans, both datasheets and the metadata - and from there in every copy downstream. There was nowhere to fix that: the build trusts the KMZ for every hut and campsite, with no layer for the few records that are wrong. So this adds one, data/site-corrections.json. A correction is keyed by the record's ArcGIS GlobalID rather than its name (names are among the things it will correct), names the record as the trust publishes it, and says why. The build refuses to apply one if the trust's record has changed under it, and fails if one matches nothing, so a correction cannot silently land on the wrong site or silently stop working. A corrected site carries a `correction` block in te-araroa.meta.json with the trust's value for anything replaced. A removed field is named there, never echoed: it is removed so as not to be published. The only correction here is the removal. A test now fails if any published phone field holds an email address. The address is still in this repository's history: it has been in out/ since the first commit, all of it on the public main branch. Rewriting that history is the owner's call, not this commit's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the trail-maps waypoint QC (eamon-b/trail-maps#218). Each was checked against the business's or DOC's own page before changing it. In the trust's records, through data/site-corrections.json: - Happy Dayz Accomodation -> Accommodation. - Wanganui Top 10 Holiday Park -> Whanganui River Top 10 Holiday Park, the park's own name (wrivertop10.co.nz); its address gets the city's official spelling, Whanganui (NZ Gazetteer place 7006). - Lake Tekapo Motels & Holiday Park -> Lakes Edge Holiday Park. The park's own site says "Formerly Lake Tekapo Motels and Holiday Park", same address and phone, and the trust's old link redirects there, so the link moves too. - Bay Of Many Coves Campsite -> Bay of Many Coves Campsite, as DOC writes it. In data/resupply.json: - Countdown -> Woolworths in all ten notes that named it. The rebrand finished in December 2025; there are no Countdown stores left. Whangarei's "Countdown and Woolworths" becomes just "Woolworths". - Lake Hāwea: Sailz is now Hāwea Store & Kitchen (33 Capell Ave: grocer, cafe, takeaways, licensed restaurant and bar, open 7 days). The old "open to 9pm" goes with it, since the new listing gives 8pm. "Red Beach Top 10" is left alone: the park's own site calls it Pinewoods Holiday Park, but TOP 10 still lists it as Red Beach TOP 10 at the same address and phone, so both names are current. data/resupply-seed.tsv is the original geocoding input and has never been kept in step with resupply.json, so it is not touched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every name here was looked up in the NZ Gazetteer (gazetteer.linz.govt.nz) and changed only where the official name differs. Place ids are in data/site-corrections.json beside each correction. The researched resupply points, in data/resupply.json, now carry the official names: Whangārei (48143), Ruakākā (39007), Māngere Bridge (28617), Ngāruawāhia (32480), Ōwhango (34824), Paekākāriki (34906) and Wānaka (6876). Pākiri Beach Holiday Park takes the macron of Pākiri (35107), which is also how the park writes its own name. The trust's route names are mostly right already, but two section names put a macron where the official name has none or has it elsewhere: - "Pataua North to Whāngārei Heads" -> Whangārei Heads (48146), which also fixes the Whangarei Heads crossing and the two gap waypoints named after it - "Arthur's Pass to Rākaia River" -> Rakaia River. The official Rakaia (4930) has no macron, and the trust's own next section already spells it that way These are corrected by exact match through a new `routeNames` map, so a name the trust fixes itself just passes through. Three places were spelt two ways. DOC's own pages use the macron for each: - Puketī Forest Hut and Puketī Recreation Area Campsite, as in the official Puketī Forest (54972); the Omahuta-Puketī bypass follows. - Top Tīmaru Hut, at the head of the Tīmaru River in Otago (44068). The Canterbury city stays Timaru, since its official name has no macron. - Pāhautea Hut Campsite, to match Pāhautea Hut beside it. The Gazetteer has no official name for Pāhautea (only an unofficial "Pahautea"), so this one follows DOC rather than the Gazetteer. Names the trust uses only internally (segment and road names) are not published and are left alone. So are business and council names where the owner's spelling could not be confirmed: Ruakaka Reserve Motor Camp, Upper and Lower Mangatawhiri campgrounds, and Wanaka Top 10 Holiday Park. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The KMZ carries no closures, so three DOC sites read as plainly reachable when they are not. Each now leads its description with a sentence saying what is closed and on whose word: - Mangatepopo Hut and Campsite: the Mangatepopo Track to Whakapapa Village has been closed indefinitely since the November 2025 Tongariro fire, and Mangatepopo Road is open only to approved shuttle operators (Te Araroa trail alert 254, last edited 10 September 2026; DOC media release of 18 May 2026). The 2026-27 route already avoids the track - both sites sit 5.4 km off it - so this is about reaching them, not the route. - Bog Inn Hut: DOC's page says Tihoi and Bog Inn Roads are closed, the hut cannot be reached on foot or by vehicle by them, and the track between Mt Pureora and Bog Inn is no longer maintained. - East Ahuriri Hut: the trust added it by hand (DOC system ID 99999, "6 Bunks"); it is not in DOC's hut data, and DOC's Quailburn Track page calls it derelict - an old mustering hut that may offer very basic shelter. Boielles Campsite's link was cut off mid-path and landed on DOC's "Page not found"; it now points at the campsite's page. The name itself is right - that page is titled Boielles Campsite - so it stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trust publishes an email address in this site's phone field. The
first commit on this branch removed it; the owner's call is that it is the
trust's own published contact for the site, so it should be shown, under
the right label, rather than dropped.
The correction layer gains `move`, which refiles a value under another
attribute without changing it, and records the move in the site's
`correction` block (`moved: { "phone": "email" }`). It refuses a move onto
a field the trust's record already has.
Private sites can now carry an `email` field. It is rendered in the
description as "Email: ..." straight after "Phone: ...", in the same way,
and the resupply plans gain an Email column after Phone.
The test that no phone field holds an email address stays, and now also
checks that no description labels an email as "Phone:". A new test checks
the Makene address appears as the site's email in meta, both resupply
plans and both GPX files, labelled as one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both are private records in the trust's KMZ with no tags at all, so the build's mapping fell through to `campsite`. Both are huts walkers sleep in: - Camp Stream Hut (km 2408.4, Two Thumb Track): DOC describes "a basic six-bunk hut", owned and managed by the Mackenzie Alpine Trust, with a recommended $10 donation. https://www.doc.govt.nz/parks-and-recreation/places-to-go/canterbury/places/te-kahui-kaupeka-conservation-park/things-to-do/huts/camp-stream-hut/ - Tin Hut (Private) (km 2565.7, Breast Hill Track): the trust's own Otago trail notes describe a 6-bunk private hut owned by Longslip Station, not covered by the Backcountry Hut Pass, available at $10 a night by honesty box or internet banking. DOC's Breast Hill Track page marks it private and says there is no camping on the farmland before the conservation area boundary, so it is neither a campsite nor somewhere walkers cannot use. https://www.doc.govt.nz/parks-and-recreation/places-to-go/otago/places/hawea-conservation-park/things-to-do/breast-hill-track/ Each gets a note saying who owns it and what it costs, since the trust's record says nothing. The correction layer gains `type`: it overrides the type the build derives, records `retyped: { from, to }` in the site's correction block, and fails if the trust's record already maps to that type, so a stale retype cannot hang around unnoticed. A note on a site with no attributes no longer leaves a dangling " | " behind it. Changing a type re-keys these waypoints in trail-maps' id registry, which matches on type: migrate their entries in the re-sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The park's own site, pinewoods.co.nz - the link the trust's record already carries - calls it Pinewoods Holiday Park, at 23 Marie Avenue, Red Beach, 09 426 4526. TOP 10 lists the same park at the same address and number as Red Beach TOP 10 Holiday Park. Both names are current, so the published name carries both. https://www.pinewoods.co.nz/ https://top10.co.nz/park/auckland/red-beach-top-10-holiday-park/ Also points Tin Hut's correction at the trail notes it was actually read from (the trust's notes page and the API it is served from) instead of a guessed URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The trust's record links to campervanpark.co.nz, which no longer resolves (no DNS answer, checked 23 October 2026), so the GPX link and the "Website:" in the description went nowhere. The link is removed; the name is kept, since listings for 263 Studholme Road disagree on who runs it now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eamon-b
added a commit
to eamon-b/trail-maps
that referenced
this pull request
Oct 23, 2026
Te Araroa takes te-araroa-data 278b521 (eamon-b/te-araroa-data#11): name and macron fixes, Countdown -> Woolworths, closure notes, Makene Road Campsite's contact refiled from phone to email, and Camp Stream Hut and Tin Hut retyped campsite -> hut. Their registry entries are migrated here, so both keep their ids; the 25 renames keep theirs too. The CDT takes cdt-data 89fbed8 (eamon-b/cdt-data#35) and the alternates rework since the September sync. That retires 62 junction and endpoint ids, mints 34 and renames 28. The CDT has no comments on the live API, so nothing is orphaned. Its POIs are re-placed on the new track (fetch:pois --reposition, no network). The five "minted beside" warnings are junctions of different alternates that meet at one point, not duplicates. trail.json keeps trail-maps' own fields; only the description's decimation figure changes (1.06% -> 1.04%). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the Te Araroa findings from the trail-maps waypoint QC (eamon-b/trail-maps#218). There are eight commits (commit 5 refiles the Makene address; commits 6–8 apply the review decisions), and each commit rebuilds
out/.The trust's site records had no override layer, so this adds one:
data/site-corrections.json. Each correction is keyed by the record's ArcGIS GlobalID, names the record as the trust publishes it, and gives a reason and a source. The build fails if a correction no longer matches its record or matches nothing. A corrected site carries acorrectionblock inte-araroa.meta.jsonthat holds the trust's original value for each field it replaced. The block also hasrouteNames, which fixes misspelt section and crossing names by exact match.Makene Road Campsite's email (commits 1 and 5)
The trust's KMZ files Makene Road Campsite's contact email address under
phone. Commit 1 removed it. On the owner's decision, commit 5 keeps it and files it as the site's email instead. The address is the trust's own published data and is probably the site's contact, so no history rewrite is needed.moveoperation in the correction layer refiles the value fromphonetoemailwithout changing it. The site'scorrectionblock recordsmoved: { "phone": "email" }.emailfield. The description shows it asEmail: …right after wherePhone: …goes, and the resupply plans gain anEmailcolumn afterPhone.Phone:label holds an email address, and that the Makene address appears as the site's email in meta, both resupply plans and both GPX files.Suggestion: tell the trust's GIS team about the mix-up so their next release files the address under email. The correction then needs removing; the build fails once the record no longer has
phone(or already hasemail), so it will prompt for that.The same records also publish the trust GIS editors' work email addresses in
creator/last_editor. These pass through tometa.jsonunchanged.Names (commit 2)
Macrons (commit 3), checked against gazetteer.linz.govt.nz
Closures and fixes (commit 4)
Decided after review (commits 6–8)
typeoverride, tested likemove.hut: a basic six-bunk hut owned by the Mackenzie Alpine Trust (DOC).hut: a private hut owned by Longslip Station with 6 bunks, $10 a night by honesty box or internet banking, and not covered by the Backcountry Hut Pass (the trust's Otago trail notes, Breast Hill Track). DOC's Breast Hill Track page says there is no camping on the private land, socampsitewould be wrong. Its description says it is private.websitelink (campervanpark.co.nz has no DNS answer, checked 23 Oct 2026) is removed. The name is kept.Booking Requiredfield still says No: Captains Creek, Middy Creek, Rocks, Browning, Hacket, Starveall, Slaty, Old Man, Mt Rintoul, Tarn, Mid Wairoa, Top Wairoa, Hunters, Porters Creek, Red Hills, Waiau, Magdalen, Hurunui, Hurunui No. 3, Locke Stream, Kiwi, Goat Pass. Follow-up: set them to Yes through the correction layer.researchedAtstays at 2026-09-08 (targeted fix, not a re-survey), anddata/resupply-seed.tsvis untouched.Retyped sites (migrate in trail-maps'
data/waypoint-ids.jsonat re-sync)Neither has an
-accessturn-off (11 m and 5 m off the route).Checks
npm run typecheck: clean.npm test: 50 pass, 0 fail, including unit tests for themoveandtypecorrections and the two output tests for the Makene email. CI passes on the head commit.npx tsx src/docs.ts: no diff.out/apart from the timestamps.For trail-maps after merge
No waypoint changes type or moves, so the registry keeps every id: a renamed waypoint reclaims its own entry by proximity, and the registry entries' names are refreshed. To update trail-maps:
npm update te-araroa-datanpm run sync:te-araroanpm run build:trails && npm run build:mobile-trailscampsitetohutindata/waypoint-ids.jsonin the same commit, so they keep their ids. Commit the rebuiltmobile/assets/trails/te_araroa.jsonand the registry name updates. Makene Road Campsite's description changes fromPhone:toEmail:.npm run publish:trail-data).🤖 Generated with Claude Code