Repository navigation
fix(mobile): bound reads by operation budget with last-read grace - #1464
Conversation
Takes over #1112. Co-authored-by: Totopo27 <35828647+Totopo27@users.noreply.github.com>
🟢 e2e web: 91 passedAll 91 tests in 41 files
e2e 0.22.0 · 1m 2s · web · run artifacts |
🟢 e2e web agent: 33 passed34 agent steps · 26 replayed from cache · 20 model calls · 85.3k tokens (85% cached) · $0.0052 All 33 tests in 5 files
e2e 0.22.0 · 2m 2s · web · run artifacts |
There was a problem hiding this comment.
All reported issues were addressed across 21 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…to deadline Also keep one read window across stale retries and name locator.waitFor in docs.
🟢 e2e android agent: 20 passed24 agent steps · 15 replayed from cache · 36 model calls · 191.6k tokens (77% cached) · $0.0151 All 20 tests in 1 file
e2e 0.22.0 · 4m 38s · android-emulator · run artifacts |
🟢 e2e ios: 55 passed, 1 skippedAll 56 tests in 7 files
e2e 0.22.0 · 5m 51s · ios-simulator · run artifacts |
🟢 e2e android: 57 passed, 1 skippedAll 58 tests in 7 files
e2e 0.22.0 · 7m 4s · android-emulator · run artifacts |
🟢 e2e ios agent: 1 flaky, 20 passed, 1 skipped25 agent steps · 12 replayed from cache · 59 model calls · 522.0k tokens (80% cached) · $0.0380
|
| Test | Agent | Time | |
|---|---|---|---|
| tests-agent/scenarios.e2e.ts · 1 flaky, 20 passed, 1 skipped | 25 steps · 59 calls | 8m 22s | |
| 🟢 | act completes Login Form | 1 step | 37.0s |
| 🟢 | act completes Infinite Scroll List | 1 step | 26.0s |
| 🟢 | act completes Modal Flow | 1 step | 9.8s |
| 🟢 | act completes Bottom Tabs | 1 step | 7.3s |
| 🟢 | act completes Text Input Variations | 1 step | 13.3s |
| 🟢 | act completes Broken Accessibility | 2 steps · 5 calls | 24.9s |
| 🟢 | act completes Vision Only | 2 steps · 6 calls | 29.9s |
| 🟢 | act completes Gestures | 1 step · 7 calls | 31.0s |
| 🟢 | act completes Async States | 1 step · 11 calls | 47.0s |
| 🟢 | act completes Debounced Search | 1 step · 1 call | 27.4s |
| 🟢 | act completes Flattened Registration Form | 2 steps · 1 call | 28.3s |
| act completes Flattened Login (1 failed attempt first) | 2 steps · 11 calls | 59.3s | |
| 🟢 | act completes Sticky Chrome Target | 1 step | 10.3s |
| 🟢 | act completes WebView Accessibility | 1 step | 11.7s |
| 🟢 | act completes Permission Prompt | 1 step | 10.6s |
| 🟢 | act completes Photo Picker | 1 step · 2 calls | 29.5s |
| 🟢 | act completes Product Catalog | 1 step | 10.0s |
| 🟢 | act completes Error Recovery | 1 step | 9.4s |
| 🟢 | act completes Choice Controls | 1 step · 7 calls | 37.3s |
| 🟢 | act completes Stripe PaymentSheet | 1 step · 8 calls | 32.2s |
| 🟢 | act completes Apple Pay | 1 step | 10.3s |
| ⏭️ | act completes Apple Pay Billing Address (skipped: the CI simulator's Apple Pay sheet skips the billing-address step, so the scenario cannot be completed there) |
e2e 0.22.0 · 9m 52s · ios-simulator · run artifacts
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Takes over #1112 by Totopo27 (closed unmerged after approval), rebased on current main with authorship credited.
@e2e-dev/mobilebounds every snapshot and screenshot by the operation's budget (oneInputBudgetper operation, including relocation and keyboard-dismiss snapshots), so a hung read fails the step instead of holding it until the test timeout.ReadWindow(packages/e2e/src/internal/time.ts): the last read may run past the deadline by the slowest read the wait has finished, capped by the phase deadline, so a slow last read still finishes and is classed asLOCATOR_NOT_FOUND/ASSERTION_FAILED, notACTION_FAILED.toHaveScreenshotwith masks makes several reads per sample).ACTION_FAILED.e2e >=0.22.0 <1. Publishede2eis 0.21.3 and a pendinge2e: minorchangeset (feat(agent)!: keep model screenshots after a secret fill #1437) makes the next release 0.22.0, which ships this. If a release goes out before this merges, the floor needs bumping again.expect(calls).toMatchObject({ resolve: 1, read: 2 })inlocator-engine.test.ts(kept).Issue
Closes #1099
Verified
Ran it locally: yes
e2e run tests/controls.e2e.ts --target ios-simulator, built packages.a missing locator fails as not found once its timeout passes(1 s timeout) isLOCATOR_NOT_FOUNDon every run, main and branch.Not covered: a slow last read on a real device. The unit tests cover it, and fail without the grace.