Skip to content

Port the rest of the operation budget for reads: observe, screenshots, positioned tap (upstream #1464) #892

Closed

Description

@kblok

Part of #869 (upstream e2e-inc/e2e#1464, commit 57f9ed9) is not ported: IEngineSession.ObserveAsync and ScreenshotAsync take no timeout, so DeviceSession.ObserveAsync, the screenshots, and the viewport probe stay unbounded. Upstream bounds them by operation.timeoutMs.

To do: add a timeout to the core session contract (a public API change), then port upstream's three its: 'bounds screenshot by operation budget', 'rethrows OPERATION_TIMEOUT from capturePixels during observe', 'shares one budget across observe steps so screenshot cannot take a fresh budget'. Also port the lateAction check of the positioned tap, with its it 'never sends a positioned tap whose target became visible past the deadline'.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

Activity

  1. kblok commented on Nov 1, 2026

    @kblok
    MemberAuthor

    An agent is working on this.

  2. kblok commented on Nov 1, 2026

    @kblok
    MemberAuthor

    Delivered by PR #909 and PR #915 (the operation budget for observe, screenshots and pixels). The positioned-tap lateAction test moved to #861.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions