Repository navigation
Enable Windows installation and verify the packaged CLI in CI - #47
Merged
Merged
Conversation
Add win32 to the package's os list and adapt three POSIX assumptions so the CLI runs on Windows: - Config/cache paths fall back to %APPDATA%\jevgrep and %LOCALAPPDATA%\jevgrep on Windows (XDG still wins first). - O_NOFOLLOW/O_NONBLOCK, undefined on Windows, fall back to 0 in the filesystem and cache open() calls. - jg skill spawns npx through a shell on Windows, where npx is npx.cmd.
Config and cache locations were resolved in three places (auth, the CLI cache, and the filesystem's protected paths). Move them into one storageDirectory() helper in @repo/core so protected storage cannot drift from where jg actually writes. scripts/package-notices.mjs split resolved paths on "/", which never matches on Windows, so `bun run build` failed there.
- Cover storageDirectory() on every platform branch. - Pass the provider preload to --import as a file URL; Node rejects a bare C:\ path. - Keep POSIX-only fixtures (file modes, chmod 0, FIFOs, pty, newline filenames) on POSIX. Link-escape checks now use junctions so they also run on Windows without symlink privilege.
dzhng
marked this pull request as ready for review
October 1, 2026 21:10
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 1, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows users cannot install Jevgrep because the npm package excludes win32. This enables installation, uses Windows profile storage when XDG overrides are absent, launches the Windows npm skill installer correctly, and keeps config/cache storage excluded from retrieval through one shared resolver.
Integrates #31 through #36 with all four contributor commits and authorship preserved. Adds Windows Node 22/24 CI against a freshly packed npm installation, fixes the remaining npm launcher and link fixtures, and prepares version 0.8.0. Closes #5 and supersedes #31/#36.
Review verdict: clean across shape, diff, and docs. Removed redundant CLI storage wrappers and duplicated protected-path arguments; clarified independent XDG overrides and linked Windows release evidence. Discovery fixture timeouts allow constrained runners to finish; result and request-budget assertions remain unchanged.
Validation on the final release commit:
bun run verifypasses: typecheck/lint, 139 Bun tests, 18 Node provider protocol tests, installer regression, 39 parser tests, four release tests, Python evaluation-harness tests, and 41 installed Linux journeys.Latest main (#46) is merged. The independent Codex CLI review could not start because its configured model is unsupported by the signed-in account; direct review was completed.