Repository navigation
Add Windows support - #31
Closed
makiisthenes wants to merge 1 commit into
Closed
makiisthenes wants to merge 1 commit into
makiisthenes wants to merge 1 commit into
Conversation
Add win32 to the package's os list and adapt three POSIX assumptions so the CLI runs on Windows: - Config/cache paths fall back to %APPDATA%\jevgrep and %LOCALAPPDATA%\jevgrep on Windows (XDG still wins first). - O_NOFOLLOW/O_NONBLOCK, undefined on Windows, fall back to 0 in the filesystem and cache open() calls. - jg skill spawns npx through a shell on Windows, where npx is npx.cmd.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
|
did you test this yourself and confirm that it works? I don't have a windows pc to test on |
Closed
Owner
|
Thank you @makiisthenes for the original Windows support and for following up with testing. Your Windows support commit is included in #47 with your authorship preserved. We also added fixes for the remaining launcher/test gaps and Windows CI on Node 22 and 24. Closing this PR as integrated through #47; the work ships in v0.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5.
npm install -g @dzhng/jevgrepfails on Windows because the packagedeclares
"os": ["darwin", "linux"]. This addswin32and fixes the fewplaces that assumed POSIX, so the CLI runs on Windows:
%APPDATA%\jevgrepand%LOCALAPPDATA%\jevgrepon Windows (XDG still wins first, macOS/Linuxunchanged).
O_NOFOLLOW/O_NONBLOCK, which are undefined on Windows, fall back to0in the filesystem and cacheopen()calls.jg skillspawnsnpxthrough a shell on Windows, wherenpxisnpx.cmd.Verified on Windows (Node 22):
bun run check-types,bun run lint,bun test ./apps/cli/test ./packages/core/test, andbun apps/cli/src/index.ts --versionall pass.