Skip to content

fix(dired): prevent dirvish redisplay feedback loop in multi-frame setups #8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hlissner merged 1 commit into from
Feb 15, 2026
Merged

fix(dired): prevent dirvish redisplay feedback loop in multi-frame setups #8664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions modules/emacs/dired/config.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ Fixes #3939: unsortable dired entries on Windows."
(dirvish-override-dired-mode)
(set-popup-rule! "^ ?\\*\\(?:[Dd]irvish\\|SIDE :: \\).*" :ignore t)

;; HACK: `dirvish-pre-redisplay-h' is called via `pre-redisplay-functions'
;; for every window that needs redisplay, but it unconditionally calls
;; `dirvish--redisplay'. When dirvish is open in multiple frames, this
;; creates a feedback loop: frame A's redisplay triggers frame B's, and
;; vice versa, causing visible flickering. Guard it so it only fires for
;; the selected window in its frame. See alexluigit/dirvish#353.
Comment thread
kovan marked this conversation as resolved.
;; REVIEW: PR this upstream!
(defadvice! +dired--debounce-dirvish-redisplay-a (fn window)
:around #'dirvish-pre-redisplay-h
(when (eq (frame-selected-window) window)
(funcall fn window)))

;; Fixes #8038. This setting is for folks who expect to be able to switch back
;; to dired buffers where the file is opened from. In other cases, don't
;; recycle sessions. We don't want leftover buffers lying around, especially
Expand Down