fix(dired): prevent dirvish redisplay feedback loop in multi-frame setups#8664
Merged
Merged
Conversation
hlissner
requested changes
Feb 13, 2026
…tups Fix: doomemacs#8355 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
f9aa4fc to
3f42ef6
Compare
Contributor
Author
|
Upstream PR submitted: alexluigit/dirvish#371 |
hlissner
approved these changes
Feb 14, 2026
Member
|
LGTM! Thanks again, and for PRing this upstream! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dirvish-pre-redisplay-h(onpre-redisplay-functions) fires for every window needing redisplay, but unconditionally callsdirvish--redisplay. When two frames each have dirvish, this creates a feedback loop: frame A's redisplay triggers frame B's and vice versa:aroundadvice that only calls the original function when the window being redisplayed is the selected window in its frame, breaking the cross-frame loopRef: alexluigit/dirvish#353
Fix: #8355
Test plan
make-frame) and open dirvish there too🤖 Generated with Claude Code