Repository navigation
Conversation
Add agentmemory as a v3 overlay mixin. The recipe installs @agentmemory/agentmemory 0.9.33, the 0.25.1 engine it pins, the state 0.22.22 and http 0.22.8 Worker Compose workers and Node.js 24.22.2 under /opt/agentmemory-sbx, each checked against a pinned SHA-256. With the engine and workers bundled, the sandbox makes no outbound requests for the service, so the kit declares no network policy. Startup hooks register the agentmemory-sbx MCP server with Claude Code and Codex and start the service on loopback port 3111 behind a lock and a livez health check. The registration hook adds the user and npm-global bin directories to PATH, because startup hooks run without a login shell, and sets CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC so the claude CLI does not contact api.anthropic.com while it registers. State is file-backed under /home/agent/.local/share/agentmemory-sbx and survives sandbox restarts. Signed-off-by: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com>
rohitg00
force-pushed
the
add-agentmemory-kit
branch
from
November 9, 2026 19:09
7aec2d7 to
16e306b
Compare
rohitg00
marked this pull request as ready for review
November 9, 2026 19:09
Author
|
@mdelapenya this ports the agentmemory kit to v3 as you asked on #334. Could you take a look when you have a moment? The fork workflows also need approval to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
agentmemoryas a v3 overlay mixin: local persistent memory for coding agents. Startup hooks register a stdio MCP server with Claude Code and Codex and start the memory service on loopback. No API keys, model downloads or sandbox egress. Replaces #334, which targeted the v2 layout.Spec choices worth flagging for review
--network=nonestage confirms the bundled CLI reports 0.9.33./opt/agentmemory-sbx, so the kit declares no network policy.127.0.0.1, with no published ports.start.shtakes a lock and waits for/agentmemory/livez, so repeated startups do not start a second service. State lives under/home/agent/.local/share/agentmemory-sbxand survivessbx stopand restart.register-mcp.shadds~/.local/binand the npm-global bin directory toPATHbefore it looks forclaudeandcodex. It also setsCLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1for those registration commands only, becauseclaude mcp getotherwise contactsapi.anthropic.com, which the e2e egress check flags.Origin
New kit for rohitg00/agentmemory.
Test plan
Verified locally with sbx v0.47.0 on Apple Silicon (linux/arm64), composed onto
./claude-ollama:scripts/test-kit.sh --validate-only agentmemory(the full TCK needs the privatekit-tck)sbx kit inspect ./agentmemory: v3 mixin, 2 startup commandsscripts/test-kit-e2e.sh agentmemorywithE2E_HOST=./claude-ollama: PASS, composed, booted and stayed inside its declared egresssbx run -d --kit ./agentmemory:claude mcp listshowsagentmemory-sbx ✔ Connected; a memory saved through MCP is recalled aftersbx stopand restart; with the service stopped, tool calls returnisErrorat once;start.shrecovers it and recall works againThe commit has a DCO sign-off and a verified signature.