Skip to content

Add agentmemory kit - #482

Open
rohitg00 wants to merge 1 commit into
docker:v3from
rohitg00:add-agentmemory-kit
Open

rohitg00 wants to merge 1 commit into
docker:v3from
rohitg00:add-agentmemory-kit

Conversation

@rohitg00

@rohitg00 rohitg00 commented Nov 9, 2026 •

Copy link
Copy Markdown

Summary

Adds agentmemory as a v3 overlay mixin: local persistent memory for coding agents. Startup hooks register a stdio MCP server with Claude Code and Codex and start the memory service on loopback. No API keys, model downloads or sandbox egress. Replaces #334, which targeted the v2 layout.

Spec choices worth flagging for review

  • Pins agentmemory 0.9.33, the 0.25.1 engine it requires, the state 0.22.22 and http 0.22.8 workers, and Node.js 24.22.2. Each download is checked against a pinned SHA-256 in the recipe, and a --network=none stage confirms the bundled CLI reports 0.9.33.
  • Everything the service needs is in the overlay under /opt/agentmemory-sbx, so the kit declares no network policy.
  • The service runs with a private home, and model-provider credentials are cleared for its process only. API, viewer and engine bind to 127.0.0.1, with no published ports.
  • start.sh takes a lock and waits for /agentmemory/livez, so repeated startups do not start a second service. State lives under /home/agent/.local/share/agentmemory-sbx and survives sbx stop and restart.
  • Startup hooks run without a login shell, so register-mcp.sh adds ~/.local/bin and the npm-global bin directory to PATH before it looks for claude and codex. It also sets CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1 for those registration commands only, because claude mcp get otherwise contacts api.anthropic.com, which the e2e egress check flags.

Origin

New kit for rohitg00/agentmemory.

Test plan

Verified locally with sbx v0.47.0 on Apple Silicon (linux/arm64), composed onto ./claude-ollama:

  • scripts/test-kit.sh --validate-only agentmemory (the full TCK needs the private kit-tck)
  • sbx kit inspect ./agentmemory: v3 mixin, 2 startup commands
  • scripts/test-kit-e2e.sh agentmemory with E2E_HOST=./claude-ollama: PASS, composed, booted and stayed inside its declared egress
  • Manual sbx run -d --kit ./agentmemory: claude mcp list shows agentmemory-sbx ✔ Connected; a memory saved through MCP is recalled after sbx stop and restart; with the service stopped, tool calls return isError at once; start.sh recovers it and recall works again

The commit has a DCO sign-off and a verified signature.

@rohitg00 rohitg00 mentioned this pull request Nov 9, 2026
6 tasks done
Add agentmemory as a v3 overlay mixin. The recipe installs
@agentmemory/agentmemory 0.9.33, the 0.25.1 engine it pins, the
state 0.22.22 and http 0.22.8 Worker Compose workers and Node.js
24.22.2 under /opt/agentmemory-sbx, each checked against a pinned
SHA-256. With the engine and workers bundled, the sandbox makes no
outbound requests for the service, so the kit declares no network
policy.

Startup hooks register the agentmemory-sbx MCP server with Claude Code
and Codex and start the service on loopback port 3111 behind a lock and
a livez health check. The registration hook adds the user and
npm-global bin directories to PATH, because startup hooks run without
a login shell, and sets
CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC so the claude CLI does not
contact api.anthropic.com while it registers. State is file-backed under
/home/agent/.local/share/agentmemory-sbx and survives sandbox restarts.

Signed-off-by: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com>
@rohitg00
rohitg00 force-pushed the add-agentmemory-kit branch from 7aec2d7 to 16e306b Compare November 9, 2026 19:09
@rohitg00
rohitg00 marked this pull request as ready for review November 9, 2026 19:09
@rohitg00
rohitg00 requested a review from a team as a code owner November 9, 2026 19:09
@rohitg00

rohitg00 commented Nov 9, 2026

Copy link
Copy Markdown
Author

@mdelapenya this ports the agentmemory kit to v3 as you asked on #334. Could you take a look when you have a moment? The fork workflows also need approval to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant