Skip to content

Add agentmemory kit - #334

Closed
rohitg00 wants to merge 3 commits into
docker:mainfrom
rohitg00:feat/agentmemory-mixin
Closed

rohitg00 wants to merge 3 commits into
docker:mainfrom
rohitg00:feat/agentmemory-mixin

Conversation

@rohitg00

@rohitg00 rohitg00 commented Sep 25, 2026 •

Copy link
Copy Markdown

Summary

Adds a schema v2 agentmemory mixin with local persistent memory for coding agents. It registers a stdio MCP server with Claude Code and Codex, starts the memory service on sandbox startup, and includes usage documentation and a repeatable MCP smoke test. No additional API key is required.

Spec choices worth flagging for review

  • Pins agentmemory 0.9.29, iii 0.11.2, and the MCP SDK 1.30.1. The iii release archive is checksum-verified; optional model packages and install scripts are disabled. agentmemory main has merged the iii 0.22.1 migration, but npm 0.9.29 still depends on iii-sdk 0.11.2. This kit follows the published pair; the agentmemory package, engine, SDK, and helpers must move together when that migration is released.
  • Runs the service in a private home with model-provider credentials cleared only for its subprocesses. The API, streams, viewer, and engine bind to loopback, without published ports or host services.
  • Uses a small MCP SDK bridge to agentmemory's REST endpoints. The upstream standalone shim can fall back to a separate store even with AGENTMEMORY_FORCE_PROXY=1; the bridge returns an error when the persistent service is unavailable.
  • Documents iii's five-second asynchronous disk-write window. The smoke test waits for the on-disk record before testing a sandbox restart. Removing the sandbox deletes its memory.
  • The three install domains were confirmed in sbx policy log: npm's registry, GitHub, and GitHub release assets. The stock Claude kit's optional apt refresh still encounters denied Ubuntu/Docker package hosts; this mixin does not use apt.

Origin

New kit for rohitg00/agentmemory.

Test plan

Verified locally with SBX v0.45.1 on Apple Silicon, using Linux arm64 templates:

  • sbx kit validate ./agentmemory
  • ./scripts/test-kit.sh agentmemory
  • ./scripts/test-kit-e2e.sh agentmemory under the isolated daemon's deny-all policy
  • Manual sbx run --detached --kit ./agentmemory claude <workspace>: Claude reports MCP connected; save, on-disk persistence, SBX stop/start, recall, service outage errors, and recovery all verified
  • Confirmed all four service sockets bind to loopback
  • Real Claude and Codex CLI registration checked twice in isolated homes, preserving an existing sibling MCP entry

Fork CI does not run the SBX e2e job; the local e2e run above covers it. All commits have DCO sign-offs and verified GitHub signatures.

Signed-off-by: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com>
Configure the worker manager explicitly and check all memory listeners in the MCP smoke test.

Signed-off-by: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com>
@rohitg00
rohitg00 requested a review from a team as a code owner September 25, 2026 12:56
Document the merged iii 0.22.1 migration and keep the npm 0.9.29 kit paired with its published 0.11.2 SDK until a compatible package is released.

Signed-off-by: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com>
@mdelapenya

Copy link
Copy Markdown
Member

As announced in #461, we'll rename main to v2 and deprecate it, and rename v3 to main. All kit contributions now need the v3 format. Could you migrate this PR using the v3 migration guide and target v3 until the renames, then main? Thanks!

🤖 Written assisted by my Codex

@rohitg00 rohitg00 mentioned this pull request Nov 9, 2026
4 tasks done
@rohitg00

rohitg00 commented Nov 9, 2026

Copy link
Copy Markdown
Author

Replaced by #482, which ports the kit to the v3 layout and agentmemory 0.9.33.

@rohitg00 rohitg00 closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants