Conversation
This was referenced Feb 23, 2024
willxinc
approved these changes
Feb 24, 2024
Collaborator
willxinc
left a comment
willxinc
left a comment
There was a problem hiding this comment.
looks good aside from a question about the return value of property_clear_error
| avs_error error; | ||
|
|
||
| error = property_get_error(prop); | ||
| property_clear_error(prop); |
Collaborator
There was a problem hiding this comment.
this returns a property* per the earlier stacked commit, is this something we need to be considering?
icex2
force-pushed
the
pr289
branch
2 times, most recently
from
1d48964 to
2e45f09
Compare
added 2 commits
February 25, 2024 09:34
After getting doubts, I looked this one up again on the assembly. The decompiled output confused me and no actual value is being returned there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(avs-util): Add helper to translate property errors
Stack created with Sapling. Best reviewed with ReviewStack.