Conversation
This was referenced Feb 23, 2024
willxinc
approved these changes
Feb 24, 2024
Collaborator
willxinc
left a comment
There was a problem hiding this comment.
pretty self explanatory, looks good to me
why does property_clear_error return a property*, is it just a passthrough?
added 2 commits
February 25, 2024 08:51
Apparently forgotten to get updated to reflect the currently supported versions correctly.
Allow hooks to cleanup when they are shut down.
added 2 commits
February 25, 2024 09:14
Improve the development experience by providing an additional docker container that can be started and used as an interactive development environment. It provides all the tools and a stable environment for building (identical to the build container).
Use these to improve error handling by allowing one to provide additional error information on property related operations.
Contributor
Author
Don't ask me. =) |
Contributor
Author
Have to correct my statement, see #299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(avs): Add property get and clear error functions
Use these to improve error handling by allowing
one to provide additional error information on
property related operations.
Stack created with Sapling. Best reviewed with ReviewStack.