Repository navigation
fix(emotes): keep emote bar reads distinct, lenient and atomic on save - #112
Merged
Merged
Conversation
diangogav
force-pushed
the
feat/emote-bar
branch
from
October 15, 2026 00:07
2964fa6 to
8a04760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INSERT ... ON CONFLICT (user_id) DO UPDATEstatement. Two concurrent first saves can no longer fail with a primary key violation.assetRefwithout assuming a trailing slash, and empty or nested slugs are ignored.Chain context
This is part of the emote packs feature: emote packs become cosmetics, and each player builds an 8-slot emote bar from the default emotes and the emotes of packs they own. The duel server already relays any emote id up to 48 bytes (diangogav/EDOpro-server-ts#418).
This is a stacked chain into
main. Merge the PRs in order. After each merge, retarget the next PR tomain.Size
328 changed lines: 104 production, 224 tests.
Verification
bun test: 683 pass, 0 fail.bun run lintandbun run build --noEmitare clean.