fix: show correct basemap for maps embedded in dashboards [DHIS2-22110] - #3772
Merged
Merged
Conversation
|
Contributor
|
🚀 Deployed on https://pr-3772.maps.netlify.dhis2.org |
7 tasks
BRaimbault
changed the title
BRaimbault
marked this pull request as ready for review
September 15, 2026 15:13
edoardo
approved these changes
Sep 17, 2026
edoardo
approved these changes
Sep 17, 2026
BRaimbault
changed the base branch from
master
to
fix/release-basemaps-fixes
September 17, 2026 13:53
Contributor
|
🎉 This PR is included in version 101.17.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-22110
Depends on dhis2/dashboard-app#3343. Safe to deploy independently either order, no regression either way.
maps-999.99.9-basemaps-rc1.2026-09-15.zip
Description
Dashboard map items always showed the default basemap instead of the configured one, on 2.43+ instances.
MapContainerdestructuredbasemap(legacy field) out of the visualization prop but notbasemaps(new field) - it fell intootherMapProps, unused by theid+mapViewsbranch that dashboard embeds hit, sogetMigratedMapConfignever saw it and fell back to default.Quality checklist
Add N/A to items that are not applicable.
Screenshots
Before:
After:
