Repository navigation
Conversation
Surefire 3.6.0 switches groups/excludedGroups to JUnit 4 category filtering when junit:junit is on the test classpath (it comes in transitively via Testcontainers). The JUnit Platform tags are then ignored: the unit-test profile runs every integration test and the integration-test and integration-h2-test profiles run none. 2.42 and 2.43 stay on 3.5.6 for the same reason.
|
Contributor
Author
|
CI here: tag selection is fixed (integration-test runs 505 + 3171 tests again, h2 1540, unit-test 8m44s). The remaining red is 2.41's MinIO test setup (18 |
4 tasks done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Restores
maven-surefire-pluginto 3.5.6 on 2.41 (bumped to 3.6.0 in #25143).Surefire 3.6.0 detects
junit:juniton the test classpath (transitive via Testcontainers) and then appliesgroups/excludedGroupsas JUnit 4 category filters instead of JUnit Platform tag filters (JUnitPlatformProvider). Our@Tags are ignored, so since #25143 on 2.41:unit-testruns all Postgres/H2 integration tests (~30 min, times out inEventAnalyticsServiceTest, e.g. fix: Skip undeletable users when removing expired invitations [DHIS2-22156] (2.41) #25379, fix: Clear invitation state when an invited user gets a password or logs in [DHIS2-22174] (2.41) #25384, chore: replace MinIO with SeaweedFS in tests [2.41] #25395)integration-testandintegration-h2-testrun 0 tests and pass2.42 and 2.43 are on 3.5.6 (the 2.42 bump #25093 was closed, the 2.43 bump #25191 is red). The dependabot 3.6.0 bump for 2.41 should be closed when it reopens.
AI Assisted