Skip to content

chore: restore maven-surefire-plugin 3.5.6 [2.41] - #25397

Closed
netroms wants to merge 1 commit into
2.41from
chore/restore-surefire-3.5.6-2.41
Closed

netroms wants to merge 1 commit into
2.41from
chore/restore-surefire-3.5.6-2.41

Conversation

@netroms

@netroms netroms commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Restores maven-surefire-plugin to 3.5.6 on 2.41 (bumped to 3.6.0 in #25143).

Surefire 3.6.0 detects junit:junit on the test classpath (transitive via Testcontainers) and then applies groups/excludedGroups as JUnit 4 category filters instead of JUnit Platform tag filters (JUnitPlatformProvider). Our @Tags are ignored, so since #25143 on 2.41:

2.42 and 2.43 are on 3.5.6 (the 2.42 bump #25093 was closed, the 2.43 bump #25191 is red). The dependabot 3.6.0 bump for 2.41 should be closed when it reopens.

AI Assisted

Surefire 3.6.0 switches groups/excludedGroups to JUnit 4 category filtering when junit:junit is on the test classpath (it comes in transitively via Testcontainers). The JUnit Platform tags are then ignored: the unit-test profile runs every integration test and the integration-test and integration-h2-test profiles run none. 2.42 and 2.43 stay on 3.5.6 for the same reason.
@sonarqubecloud

Copy link
Copy Markdown

@netroms

netroms commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

CI here: tag selection is fixed (integration-test runs 505 + 3171 tests again, h2 1540, unit-test 8m44s). The remaining red is 2.41's MinIO test setup (18 AppManagerMinIOTest errors, MinIO image pull unauthorized in api-test), which #25395 fixes. With both PRs combined, every check is green: #25398 (run 36258546394). #25395 has the mirror problem: its unit-test fails only because of the Surefire tag bug fixed here. One of them has to merge first.

@netroms

netroms commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Folded into #25395 (commit 66dc87a), since neither PR is green on its own.

@netroms netroms closed this Sep 26, 2026
@netroms
netroms deleted the chore/restore-surefire-3.5.6-2.41 branch September 26, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant