Repository navigation
chore: replace MinIO with SeaweedFS in tests [2.41] - #25395
Merged
Merged
Conversation
Backport of #25373. quay.io/minio/minio now returns 401 on pull, breaking the S3-backed integration tests and the e2e compose setup. Use SeaweedFS with only its S3 gateway enabled instead. Adapted to 2.41: the branch configures the S3 store through MinIOConfiguration/MinIOConfigurationProvider rather than a JUnit extension; they are renamed to S3Configuration/S3ConfigurationProvider and start a SeaweedFS container. (cherry picked from commit f642b56)
This was referenced Sep 26, 2026
Contributor
Author
Surefire 3.6.0 switches groups/excludedGroups to JUnit 4 category filtering when junit:junit is on the test classpath (it comes in transitively via Testcontainers). The JUnit Platform tags are then ignored: the unit-test profile runs every integration test and the integration-test and integration-h2-test profiles run none. 2.42 and 2.43 stay on 3.5.6 for the same reason.
|
teleivo
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25373 to
2.41.Summary
quay.io/minio/minionow returns 401 on pull, breakingAppManagerMinIOTestand the api-test docker compose on this branch.chrislusf/seaweedfs:4.47, S3 gateway only) in the test config and e2e compose; drop thetestcontainers:miniodependency.MinIOConfiguration/MinIOConfigurationProviderinstead of a JUnit extension; they becomeS3Configuration/S3ConfigurationProviderand start SeaweedFS.AppManagerMinIOTest->AppManagerS3Test.maven-surefire-plugin3.5.6 (was 3.6.0 since chore(deps): bump maven-surefire-plugin.version from 3.5.6 to 3.6.0 in /dhis-2 #25143). Withjunit:juniton the test classpath, 3.6.0 readsgroups/excludedGroupsas JUnit 4 categories and ignores our JUnit tags, sounit-testran every integration test (EventAnalyticsServiceTesttimeout) andintegration-test/integration-h2-testran none. 2.42/2.43 are on 3.5.6.Test plan
AppManagerS3Testagainst SeaweedFS, 18 passed, 0 failures/errors/skipss3service reaches healthy; bucket create/put/list with thedhis.confcredentials works ons3:8333AI Assisted