Skip to content

chore: gate the sharing dialog search box and keep e2e failure artifacts #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karolinelien wants to merge 1 commit into from
+24 −1
Closed

chore: gate the sharing dialog search box and keep e2e failure artifacts #4730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,16 @@ jobs:
CYPRESS_dhis2Password_trackerAutoTestRestricted: ${{ secrets.CYPRESS_DHIS2_PASSWORD_TRACKER_AUTO_TEST_RESTRICTED }}
NODE_OPTIONS: "--openssl-legacy-provider"

- uses: actions/upload-artifact@v7
if: failure()
with:
name: cypress-failure-${{ matrix.versions }}-${{ matrix.spec-group.id }}
path: |
cypress/screenshots
cypress/videos
if-no-files-found: ignore
retention-days: 7

call-e2e-tests-result:
needs: cypress
uses: ./.github/workflows/e2e-tests-result.yml
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/verify-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,16 @@ jobs:
CYPRESS_dhis2Password_trackerAutoTestRestricted: ${{ secrets.CYPRESS_DHIS2_PASSWORD_TRACKER_AUTO_TEST_RESTRICTED }}
NODE_OPTIONS: "--openssl-legacy-provider"

- uses: actions/upload-artifact@v7
if: failure()
with:
name: cypress-failure-dev-${{ matrix.spec-group.id }}
path: |
cypress/screenshots
cypress/videos
if-no-files-found: ignore
retention-days: 7

build:
runs-on: ubuntu-latest
needs: [lint, typescript, unit-tests]
Expand Down
5 changes: 4 additions & 1 deletion cypress/e2e/WorkingLists/sharedSteps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ Then(/^you can load the view with the name ?(.*)$/, (name) => {
When('you change the sharing settings', () => {
cy.get('[data-test="list-view-menu-button"]').click();
cy.contains('Share view').click();
cy.get('[placeholder="Search"]').type('Boateng');
cy.get('[data-test="sharing-dialog"]')
.find('[placeholder="Search"]')
.should('be.enabled')
.type('Boateng');
cy.contains('Kevin Boateng').click();
cy.contains('Choose a level').click();
cy.contains('View and edit').click({ force: true });
Expand Down
Loading