chore: gate the sharing dialog search box and keep e2e failure artifacts - #4730
Closed
karolinelien wants to merge 1 commit into
Closed
chore: gate the sharing dialog search box and keep e2e failure artifacts#4730karolinelien wants to merge 1 commit into
karolinelien wants to merge 1 commit into
Conversation
`you change the sharing settings` clicked "Share view" and typed into the
dialog's search box with nothing in between. The box is disabled while the
dialog loads the object's sharing state, and `cy.type()` does not wait for
that to clear - the CI error carries no "Timed out retrying" prefix, so it
threw immediately rather than after the command timeout. `cy.get` only
retried until the input existed, which it does while still disabled.
Gate it with a retrying `should('be.enabled')` and scope the lookup to the
dialog, the way the newer WorkingListsSharing step already does - the bare
`[placeholder="Search"]` would match any search box on the page.
This is the failure seen on `cypress (2.42, 5)` and, on another branch, on
`cypress (2.43, 5)` - same scenario, same error, different version, so it is
a race rather than anything version specific.
Neither cypress job kept its screenshots or videos: recording to Cypress
Cloud is opt-in through `[e2e record]` or the `e2e record` label, and nothing
uploaded the local artifacts, so a failing shard left nothing to look at.
Upload them on failure only, with a short retention.
Verified against play stable-2-43-1: both sharing scenarios pass with the
gate in place.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The sharing dialog search box.
you change the sharing settingsclicks Share view and types into the dialog's search box with nothing in between. That box is disabled while the dialog loads the object's sharing state, andcy.type()does not wait for the disabled state to clear — the CI error carries noTimed out retryingprefix, so it threw immediately rather than after the command timeout.cy.getretried only until the input existed, which it does while still disabled.Not version specific: the same scenario fails the same way on
cypress (2.42, 5)here and oncypress (2.43, 5)on another branch. It is a race.Failure artifacts. Neither cypress job kept its screenshots or videos. Recording to Cypress Cloud is opt-in via
[e2e record]or thee2e recordlabel, and nothing uploaded the local ones — so a failing shard left nothing to look at. One sharing failure on 2.41 is still undiagnosed for exactly this reason.What
should('be.enabled'), and scope the lookup to[data-test="sharing-dialog"]the way the newerWorkingListsSharingstep already does — the bare[placeholder="Search"]would match any search box on the page.cypress/screenshotsandcypress/videoson failure only, 7-day retention, in both the version matrix (e2e-tests.yml) and the dev shards (verify-app.yml).Verification
Ran
TrackerWorkingListsUser.featureagainstplay.im.dhis2.org/stable-2-43-1with the gate in place: both sharing scenarios pass, includingThe Program stage custom working can be shared, the one failing in CI. One unrelated scenario fails locally on demo-data counts (Show only teis with active enrollments and unassinged eventsexpects 4 rows, play has 3).Both workflow files were parsed to confirm the new step lands on the right job with
if: failure().AI Assisted.