Repository navigation
test(dt1f1): re-pin the 2010 20-F item lengths after #1361; assert passage counts - #1401
Merged
Merged
Conversation
…ssage counts test_2010_20f_resolves_all_eight_wrapped_items_without_the_legacy_parser has failed locally since #1361 (bf0441b, bisected from 66e3d48 where the pins held): Item 5 107,457 -> 106,096, Item 6 58,425 -> 57,677, Item 11 7,504 -> 7,081. It skips in CI because its fixture lives in the gitignored text_boundary_corpus, so nobody saw it; #1386 then took 3 whitespace characters off Item 5 (word stream identical). The shrinkage is #1361 removing duplicates, not losing text. Against the source's own item spans: Item 5's technology transfer (July 2009) and W2E license (January 2010) paragraphs occur once and were printed twice; Item 6's "247,900", "Company Headcount", "100,000" (4), "50,000" (11) and "(2)" (15) were each printed once too often; Item 11's forward-contract paragraph ("notional amount of $1,695") occurs once in Item 11 (its other copy is in Item 19's notes) and was printed twice. After #1361 every count matches the source. Re-pinned, with count assertions for those passages so the next change is judged on content rather than length; they fail on bf0441b~1. The other 40 tests on the ignored corpus pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dgunning
enabled auto-merge (squash)
October 1, 2026 23:20
dgunning
added a commit
that referenced
this pull request
Oct 2, 2026
… so CI runs them (#1403) Three regression tests read fixtures from the gitignored tests/fixtures/text_boundary_corpus and carried skipif(not exists), so they skipped in CI and only ever ran on a developer machine. One of them (dt1f1's 2010 20-F) went stale for five days after #1361 changed three item lengths, because only the CI-visible pins were updated (re-pinned in #1401). Copied into tests/fixtures/parity_gate, the convention the 99-001234, 10-073212 and 16-000635 fixtures already follow: - 10-K/0000927356-01-000369.html (0.3 MB; test_3dp_bare_textnode_headers) - 10-K/0001193125-21-101193.html (43 KB; test_dt1f1_item_9at) - 20-F/0001144204-10-017467.html (3.5 MB; test_dt1f1_wrapped_item_headers) The tests point at the tracked copies, lose their skipif, and their CORPUS NOTEs say so. The section parity ratchet lists the three in TRACKED_GAP_FIXTURES so they cannot quietly disappear; parity_benchmark's build_corpus labels both trees by accession and prefers the tracked copy, so no local ratchet result moves. Verified in a detached worktree (no ignored corpus, CI's view): the three files plus the section ratchet, 23 passed, 0 skipped. Locally: the three parity ratchets 16 passed, fast regression 3,472 passed, check_regression_skips OK. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_2010_20f_resolves_all_eight_wrapped_items_without_the_legacy_parserhas failed on every localtest-fastrun since #1361. It skips in CI, because its fixture is in the gitignoredtext_boundary_corpus, which is why main's CI stayed green.What happened
The shrinkage is #1361 removing duplicates, not losing text. I counted each changed passage against the source's own item span:
Change
Open question
Seven test files depend on the gitignored corpus and can only fail on a developer machine; this one stayed broken for five days. Its 20-F fixture is 3.7 MB, against 366 MB of tracked fixtures in
tests/fixtures/html. Moving the fixtures these tests use into the tracked corpus would let CI run them.🤖 Generated with Claude Code