Repository navigation
test: track the three era-corpus fixtures regression tests assert on, so CI runs them - #1403
Merged
Merged
Conversation
… so CI runs them Three regression tests read fixtures from the gitignored tests/fixtures/text_boundary_corpus and carried skipif(not exists), so they skipped in CI and only ever ran on a developer machine. One of them (dt1f1's 2010 20-F) went stale for five days after #1361 changed three item lengths, because only the CI-visible pins were updated (re-pinned in #1401). Copied into tests/fixtures/parity_gate, the convention the 99-001234, 10-073212 and 16-000635 fixtures already follow: - 10-K/0000927356-01-000369.html (0.3 MB; test_3dp_bare_textnode_headers) - 10-K/0001193125-21-101193.html (43 KB; test_dt1f1_item_9at) - 20-F/0001144204-10-017467.html (3.5 MB; test_dt1f1_wrapped_item_headers) The tests point at the tracked copies, lose their skipif, and their CORPUS NOTEs say so. The section parity ratchet lists the three in TRACKED_GAP_FIXTURES so they cannot quietly disappear; parity_benchmark's build_corpus labels both trees by accession and prefers the tracked copy, so no local ratchet result moves. Verified in a detached worktree (no ignored corpus, CI's view): the three files plus the section ratchet, 23 passed, 0 skipped. Locally: the three parity ratchets 16 passed, fast regression 3,472 passed, check_regression_skips OK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three regression tests read fixtures from the gitignored
tests/fixtures/text_boundary_corpuswithskipif(not exists), so they only ever ran on a developer machine. One of them, dt1f1's 2010 20-F test, went stale for five days after #1361 (re-pinned in #1401).Change
The three files are copied into
tests/fixtures/parity_gate, the convention the existing gate fixtures already follow:10-K/0000927356-01-000369.htmltest_3dp_bare_textnode_headers10-K/0001193125-21-101193.htmltest_dt1f1_item_9at20-F/0001144204-10-017467.htmltest_dt1f1_wrapped_item_headersskipif, and their CORPUS NOTEs explain why.test_section_parity_ratchet.TRACKED_GAP_FIXTURESlists all three, so they can't quietly disappear.build_corpuslabels both trees by accession and prefers the tracked copy, so no local ratchet result moves.Verification
check_regression_skips.pyis OK.🤖 Generated with Claude Code