Skip to content

Fixing tree slicing bug and adding attribute argument to constant process #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wsdewitt merged 4 commits into from
Oct 21, 2025
Merged

Fixing tree slicing bug and adding attribute argument to constant process #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
947d7a5
fixing slicing bug
magdalenarussell Oct 20, 2025
3207736
adding optional state argument to constant process
magdalenarussell Oct 20, 2025
a553d5c
removing is_root to satisfy the type checker
magdalenarussell Oct 21, 2025
0f4d9cc
simpler time interval check syntax
wsdewitt Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bdms/poisson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,12 @@ class ConstantProcess(HomogeneousProcess):

Args:
value: Constant rate.
attr: The name of the :py:class:`bdms.TreeNode` attribute to access. This
is not used by this process, but is included for downstream compatibility.
"""

def __init__(self, value: float = 1.0):
super().__init__()
def __init__(self, value: float = 1.0, attr: str = "state"):
super().__init__(attr=attr)
self.value = value

def λ_homogeneous(
Expand Down
3 changes: 1 addition & 2 deletions bdms/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,7 @@ def slice(self, t: float, attr: str = "x") -> list[Any]:
return [getattr(self, attr)]

def is_leaf_fn(node: TreeNode):
assert node.up is not None
return node.t >= t and node.up.t < t
return node.up is not None and (node.up.t < t <= node.t)

return [
(getattr(node, attr) if node.t == t else getattr(node.up, attr))
Expand Down