Fixing tree slicing bug and adding attribute argument to constant process - #13
Merged
Conversation
magdalenarussell
marked this pull request as draft
October 20, 2025 23:07
magdalenarussell
marked this pull request as ready for review
October 21, 2025 19:01
Contributor
Author
|
To pass the type checker, it seemed necessary to have CC @wsdewitt |
wsdewitt
approved these changes
Oct 21, 2025
wsdewitt
left a comment
wsdewitt
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I made a minor suggestion to make the time interval check slightly simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #11 by removing the assertion error from the tree-slicing method. It also adds an optional attribute argument to the ConstantProcess subclass, making it compatible with mutator classes that operate based on non-default node attributes.