Skip to content

style(format): normalize master promotion range [skip release] #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kattsushi merged 1 commit into from
Aug 27, 2026
Merged

style(format): normalize master promotion range [skip release] #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions apps/react-router-example/app/routes/api.hatchet.runs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,20 @@ import { greetingInput, greetingTask } from "../lib/hatchet/greeting-task.server
import { withActionEffect } from "../lib/runtime.server.js"

const invalidRequest = () =>
Response.json(
{ ok: false, errors: ["Request body must contain a non-empty name"] },
{ status: 400 },
)
Response.json({ ok: false, errors: ["Request body must contain a non-empty name"] }, { status: 400 })

const decodeInput = (request: Request) =>
Effect.tryPromise({
try: async (): Promise<unknown> => request.json(),
catch: invalidRequest,
}).pipe(
Effect.flatMap(Schema.decodeUnknownEffect(greetingInput)),
Effect.mapError(invalidRequest),
)
}).pipe(Effect.flatMap(Schema.decodeUnknownEffect(greetingInput)), Effect.mapError(invalidRequest))

export const action = Effect.gen(function*() {
export const action = Effect.gen(function* () {
const { request } = yield* ActionArgsContext
if (request.method !== "POST") {
return yield* Effect.fail(
Response.json(
{ ok: false, errors: ["Only POST is supported"] },
{ status: 405 },
),
)
return yield* Effect.fail(Response.json({ ok: false, errors: ["Only POST is supported"] }, { status: 405 }))
}
const input = yield* decodeInput(request)
const handle = yield* Hatchet.runNoWait(greetingTask, input)
return Response.json({ ok: true, runId: handle.id }, { status: 202 })
}).pipe(
withBetterAuthGuardAction.with({ redirectOnFail: "/login" }),
withActionEffect,
)
}).pipe(withBetterAuthGuardAction.with({ redirectOnFail: "/login" }), withActionEffect)
104 changes: 29 additions & 75 deletions apps/react-router-example/app/routes/hatchet-crons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,35 +30,26 @@ export const actionErrorFromData = (data: unknown): string | undefined => {
return decoded.success.errors[0]
}

export const loader = Effect.gen(function*() {
export const loader = Effect.gen(function* () {
const crons = yield* Hatchet.listCrons({ taskName: greetingTask.name })
return yield* httpSuccess({ crons })
}).pipe(
withBetterAuthGuard.with({ redirectOnFail: "/login" }),
withLoaderEffect,
)
}).pipe(withBetterAuthGuard.with({ redirectOnFail: "/login" }), withLoaderEffect)

export const action = Effect.gen(function*() {
export const action = Effect.gen(function* () {
const { request } = yield* ActionArgsContext
const formData = yield* Effect.result(
Effect.tryPromise(() => request.formData()),
)
const formData = yield* Effect.result(Effect.tryPromise(() => request.formData()))
if (Result.isFailure(formData)) {
return yield* httpFailure("Invalid cron form")
}

const decoded = yield* Effect.result(
Schema.decodeUnknownEffect(cronForm)(
Object.fromEntries(formData.success.entries()),
),
Schema.decodeUnknownEffect(cronForm)(Object.fromEntries(formData.success.entries())),
)
if (Result.isFailure(decoded)) {
return yield* httpFailure("Invalid cron form")
}

const schedule = yield* Effect.result(
CronExpression.parse(decoded.success.expression),
)
const schedule = yield* Effect.result(CronExpression.parse(decoded.success.expression))
if (Result.isFailure(schedule)) {
return yield* httpFailure("Invalid cron expression")
}
Expand All @@ -69,50 +60,32 @@ export const action = Effect.gen(function*() {
input: { name: decoded.success.greetingName },
})
return yield* httpRedirect("/hatchet-crons")
}).pipe(
withBetterAuthGuardAction.with({ redirectOnFail: "/login" }),
withActionEffect,
)
}).pipe(withBetterAuthGuardAction.with({ redirectOnFail: "/login" }), withActionEffect)

interface HatchetCronsScreenProps {
readonly crons: ReadonlyArray<CronRecord>
readonly actionError?: string
}

export function HatchetCronsScreen({
crons,
actionError,
}: HatchetCronsScreenProps) {
export function HatchetCronsScreen({ crons, actionError }: HatchetCronsScreenProps) {
const [expression, setExpression] = useState(defaultCronSource)
const schedule = CronExpression.parseResult(expression)
const upcoming = Result.isSuccess(schedule)
? CronExpression.nextRuns(schedule.success, 3)
: []
const upcoming = Result.isSuccess(schedule) ? CronExpression.nextRuns(schedule.success, 3) : []

return (
<main className="container">
<article>
<h2>Hatchet Crons</h2>
<p>
Create authenticated cron triggers for the registered greeting task.
</p>
<p>Create authenticated cron triggers for the registered greeting task.</p>

<section aria-labelledby="create-cron-heading">
<h3 id="create-cron-heading">Create cron</h3>
<Form method="post">
<fieldset>
<label htmlFor="cron-name">Cron name</label>
<input
id="cron-name"
name="name"
type="text"
required
placeholder="weekday-greeting"
/>
<input id="cron-name" name="name" type="text" required placeholder="weekday-greeting" />

<label htmlFor="cron-expression">
Five-field cron expression
</label>
<label htmlFor="cron-expression">Five-field cron expression</label>
<input
id="cron-expression"
name="expression"
Expand All @@ -121,50 +94,34 @@ export function HatchetCronsScreen({
value={expression}
onChange={(event) => setExpression(event.currentTarget.value)}
/>
{Result.isFailure(schedule) ?
(
<small role="status">
Enter a valid five-field cron expression.
</small>
) :
null}
{Result.isFailure(schedule) ? (
<small role="status">Enter a valid five-field cron expression.</small>
) : null}

<label htmlFor="greeting-name">Greeting name</label>
<input
id="greeting-name"
name="greetingName"
type="text"
required
placeholder="Ada"
/>
<input id="greeting-name" name="greetingName" type="text" required placeholder="Ada" />
</fieldset>

<section aria-labelledby="cron-preview-heading">
<h4 id="cron-preview-heading">Next three local occurrences</h4>
{upcoming.length === 0 ? <p>Enter a valid expression to preview upcoming runs.</p> : (
{upcoming.length === 0 ? (
<p>Enter a valid expression to preview upcoming runs.</p>
) : (
<ol>
{upcoming.map((date) => (
<li key={date.toISOString()}>
<time dateTime={date.toISOString()}>
{date.toLocaleString()}
</time>
<time dateTime={date.toISOString()}>{date.toLocaleString()}</time>
</li>
))}
</ol>
)}
</section>

{actionError ?
(
<small
role="alert"
aria-live="assertive"
style={{ color: "var(--pico-color-red-500)" }}
>
{actionError}
</small>
) :
null}
{actionError ? (
<small role="alert" aria-live="assertive" style={{ color: "var(--pico-color-red-500)" }}>
{actionError}
</small>
) : null}
<button type="submit" disabled={Result.isFailure(schedule)}>
Create cron
</button>
Expand All @@ -173,7 +130,9 @@ export function HatchetCronsScreen({

<section aria-labelledby="cron-list-heading">
<h3 id="cron-list-heading">Cron list</h3>
{crons.length === 0 ? <p>No crons found.</p> : (
{crons.length === 0 ? (
<p>No crons found.</p>
) : (
<ul>
{crons.map((cron) => (
<li key={cron.id}>
Expand Down Expand Up @@ -208,10 +167,5 @@ export default function HatchetCrons({ loaderData }: Route.ComponentProps) {
)
}

return (
<HatchetCronsScreen
crons={loaderData.data.crons}
actionError={actionError}
/>
)
return <HatchetCronsScreen crons={loaderData.data.crons} actionError={actionError} />
}
Loading
Loading