Repository navigation
Add expanded Transient Shaper and Multiband Compressor windows - #92
Merged
Merged
Conversation
Transient Shaper's window scopes the output with the gain it applied, and its card holds a picture of a model hit whose handles set Attack, Sustain and their times. Multiband Compressor's window draws each band's level, gain, threshold and up threshold on a frequency axis with draggable crossovers, and its rack card edits the band picked in its Band menu beside that band's transfer curve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Transient Shaper, before and after:
Multiband Compressor, before and after:
Benchmark
Rebuild cost per frame, release build (
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture). Windows rebuild only while they are open.Tests
transient_shaper_window_sets_times_from_the_picture,model_hit_follows_attack_and_sustainmultiband_window_edits_the_selected_bandcargo test -p dstudio-app --release: 304 passed. Clippy and fmt are clean.Generated by Claude Code