Repository navigation
Add expanded Delay and Reverb windows - #93
Merged
Merged
Conversation
Both windows draw their card's field at the display's size and route its pointer events through the card's field handlers with the window's geometry. Delay's header carries Link, Sync, Hold view, the views, Dry and the mode, and its card's band column edits the repeat-EQ band picked in its Band menu. Reverb opens a 1200 pt window whose Filter range drags Low Cut and High Cut.
chrislaupama
force-pushed
the
device-windows-7
branch
from
November 15, 2026 21:33
0f04a91 to
3b14d2f
Compare
Merged
chrislaupama
marked this pull request as ready for review
November 15, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field_canvas) at the display's size. The display's pointer events go through the card's field handlers, which hit-test the window's plot while the event comes from the window (field_size). Wash images are keyed by device and surface, so the window's reverb tail image doesn't replace the card's.--window-heightoption for screenshots of tall windows.Screenshots
Delay, before and after:
Reverb, before and after:
Benchmark
Rebuild cost per frame, release build (
cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture). Windows rebuild only while they are open.Tests
delay_window_shows_the_field_and_the_selected_band: header controls, the band picker, the EQ view caption, and the hit-test size inside the window.reverb_window_drags_the_filter_range: range zones, shimmer dimming, and handle movement.cargo test -p dstudio-app --release: 306 passed. Clippy (-D warnings) and fmt are clean.