Skip to content

Add expanded Delay and Reverb windows - #93

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-7
Nov 15, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-7

Conversation

@chrislaupama

@chrislaupama chrislaupama commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Shared field windows: Delay and Reverb draw their card's field (field_canvas) at the display's size. The display's pointer events go through the card's field handlers, which hit-test the window's plot while the event comes from the window (field_size). Wash images are keyed by device and surface, so the window's reverb tail image doesn't replace the card's.
  • Delay: the header holds Link, Sync, Hold view, the Echoes / EQ view, Dry and the mode. The display caption names the echo time, or the feedback filter band in the EQ view. The card has the times, Feedback and Grit, the wobble and width, a band column (a Band On latch over a Band menu) with that band's Freq, Gain and Q, and Mix.
  • Reverb: a 1200 × 700 pt window. The header holds the Tail / EQ view, Dry and the mode. The tail picture fills the display, the card's Filter range has two handles that drag Low Cut and High Cut, and the shimmer shifts and amount light only in Shimmer mode.
  • Hold view freezes a field window's live picture.
  • New --window-height option for screenshots of tall windows.
  • README, docs/devices.md and CHANGELOG are updated.

Screenshots

Delay, before and after:

before
after

Reverb, before and after:

before
after

Benchmark

Rebuild cost per frame, release build (cargo test -p dstudio-app --release bench_dynamics_windows -- --ignored --nocapture). Windows rebuild only while they are open.

Device Card Window
Delay 22.0 µs 29.2 µs
Reverb 74.5 µs 167.3 µs

Tests

  • delay_window_shows_the_field_and_the_selected_band: header controls, the band picker, the EQ view caption, and the hit-test size inside the window.
  • reverb_window_drags_the_filter_range: range zones, shimmer dimming, and handle movement.
  • cargo test -p dstudio-app --release: 306 passed. Clippy (-D warnings) and fmt are clean.

Both windows draw their card's field at the display's size and route its pointer
events through the card's field handlers with the window's geometry. Delay's
header carries Link, Sync, Hold view, the views, Dry and the mode, and its card's
band column edits the repeat-EQ band picked in its Band menu. Reverb opens a 1200
pt window whose Filter range drags Low Cut and High Cut.
@chrislaupama
chrislaupama marked this pull request as ready for review November 15, 2026 22:08
@chrislaupama
chrislaupama merged commit f356a19 into main Nov 15, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-7 branch November 15, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant