Repository navigation
Add expanded windows for Tremolo, Auto-Panner, Chorus, Flanger, Phaser and Ring Mod - #87
Merged
Merged
Conversation
…r and Ring Mod The plotted-field devices now open an expanded window: the card's curve model drawn in its window form (taller ladder, a time or frequency axis with units, a legend naming each series), In and Out meters, and every control on one card row. Dragging the plot moves the same two parameters as the card's field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tremolo, Auto-Panner, Chorus, Flanger, Phaser and Ring Mod now open an expanded window from the window button instead of the card in a window.
device_fields::Input::win): a taller ladder, a time axis (Tremolo, Auto-Panner, Ring Mod) or frequency axis (Chorus, Flanger, Phaser) with units under the plot, and a legend naming each series (Gain/Modulation, Pan/Off center, Comb or Notches/Sweep/Right). New code lives indevice_window_fields.rs.WinMetergainslabel-xso the labels centre on their bars.device_window::kit). Ring Mod's window is 860 pt wide.Screenshots
Device only, cropped to the window. Before: the card in a window. After: the expanded window.
Benchmarks
cargo test -p dstudio-app --release bench_field_windows -- --ignored --nocapturemeasures how long it takes to build the card and the whole window once, averaged over 500 builds (4-core Xeon @ 2.1 GHz, Linux).The window plots about one sample per pixel across a plot roughly 2.5 times wider than the card's, and every build stays under 1 ms. Windows only build while they are open. The audio path is unchanged.
Docs
Generated by Claude Code