Skip to content

Add expanded windows for Tremolo, Auto-Panner, Chorus, Flanger, Phaser and Ring Mod - #87

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-2
Nov 15, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-2

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

What

Tremolo, Auto-Panner, Chorus, Flanger, Phaser and Ring Mod now open an expanded window from the window button instead of the card in a window.

  • Display: the card's own curve model drawn in its window form (device_fields::Input::win): a taller ladder, a time axis (Tremolo, Auto-Panner, Ring Mod) or frequency axis (Chorus, Flanger, Phaser) with units under the plot, and a legend naming each series (Gain/Modulation, Pan/Off center, Comb or Notches/Sweep/Right). New code lives in device_window_fields.rs.
  • Drag: dragging the plot moves the same two parameters as the card's field (across: Rate or Frequency; up: Depth, Feedback or Bias).
  • Meters: In and Out meters sit in a narrower strip beside the display. WinMeter gains label-x so the labels centre on their bars.
  • Controls: every control sits on one card row: Timebase, Rate and Depth; the device's Shape, Voices, Mode or Stages pills; then Feedback, Width, Mix and Output.
  • Window size: each device has its own (device_window::kit). Ring Mod's window is 860 pt wide.
  • Tests: window plots carry an axis and a legend; every field window places each control once inside the face; tick and time-label formatting.

Screenshots

Device only, cropped to the window. Before: the card in a window. After: the expanded window.

Before After

Benchmarks

cargo test -p dstudio-app --release bench_field_windows -- --ignored --nocapture measures how long it takes to build the card and the whole window once, averaged over 500 builds (4-core Xeon @ 2.1 GHz, Linux).

Device Card Window
Tremolo 126 µs 226 µs
Auto-Panner 130 µs 252 µs
Chorus 266 µs 603 µs
Flanger 204 µs 508 µs
Phaser 211 µs 633 µs
Ring Mod 86 µs 224 µs

The window plots about one sample per pixel across a plot roughly 2.5 times wider than the card's, and every build stays under 1 ms. Windows only build while they are open. The audio path is unchanged.

Docs

  • README.md is still accurate (devices section lists the new windows)
  • docs/devices.md (expanded windows) and CHANGELOG.md updated

Generated by Claude Code

…r and Ring Mod

The plotted-field devices now open an expanded window: the card's curve
model drawn in its window form (taller ladder, a time or frequency axis
with units, a legend naming each series), In and Out meters, and every
control on one card row. Dragging the plot moves the same two parameters
as the card's field.
@chrislaupama
chrislaupama marked this pull request as ready for review November 15, 2026 12:05
@chrislaupama
chrislaupama merged commit 18750cc into main Nov 15, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-2 branch November 15, 2026 17:56
@chrislaupama chrislaupama mentioned this pull request Nov 15, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant