Skip to content

Add the expanded Character Mod window - #88

Merged
chrislaupama merged 1 commit into
mainfrom
device-windows-3
Nov 15, 2026
Merged

chrislaupama merged 1 commit into
mainfrom
device-windows-3

Conversation

@chrislaupama

Copy link
Copy Markdown
Collaborator

What

Character Mod's window button now opens its expanded window instead of the card in a window. It is 960 × 520 pt.

  • Display: the card's motion model in its window form. The caption names the circuit and mode ("Twin BBD · I") with the range it travels.
    • The ruler reads in the circuit's own unit: ms delay, a log Hz sweep, dB gain or pan.
    • The time axis has one rule per LFO cycle.
    • A band shows the range the series travel.
    • The legend names each series (Left/Right, Voice 1–3, Horn/Drum, …) and the Sweep band.
  • Drag: dragging the plot sets Rate (or Note) across and Depth up, as on the card.
  • Main card: Character and Mode pickers, Timebase, Rate, Depth and Mix, then Width, Drift and Voice. Ensemble has no Mode, so its picker leaves the row.
  • Rack card: Input (Off/Lo/Hi), the circuit's artifacts (Hiss, Drive, Darken, Wow; any the circuit lacks leave the row), Depth-M and Depth-S, Seed, Mono and Output.
    • Seed is a lit "Take N" pill: a click plays the next take, wrapping at 9999 (new window action ACT_SEED).
  • Tests: window rows per circuit (artifacts, no Mode on Ensemble, the Seed take wraps), and the window plot's caption, unit and legend.

Screenshots

Device only, cropped to the window.

Before After

Benchmarks

cargo test -p dstudio-app --release bench_field_windows -- --ignored --nocapture gives the time for one build of the card and of the window, averaged over 500 builds (4-core Xeon @ 2.1 GHz, Linux).

Device Card Window
Character Mod 179 µs 279 µs

The other field windows are unchanged and within noise of #87 (for example Tremolo 250 µs, Phaser 624 µs). Windows only build while they are open, and the audio path is unchanged.

Docs

  • README.md is still accurate (devices section)
  • docs/devices.md and CHANGELOG.md updated

Generated by Claude Code

The window plots the circuit's motion in its own unit (ms delay, Hz
sweep, dB gain or pan) with one rule per LFO cycle, the band its series
travel and a legend naming them, captioned with the circuit and its mode.
The circuit and LFO controls sit on the main card; the rack card holds
Input, the circuit's artifacts (those it lacks leave the row), Depth-M
and Depth-S, Seed (a click plays the next take), Mono and Output.
@chrislaupama
chrislaupama merged commit 408540f into main Nov 15, 2026
13 checks passed
@chrislaupama
chrislaupama deleted the device-windows-3 branch November 15, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant