fix(render): resolve a relative stylesheet root before comparing it - #532
Conversation
loadApp('.') from /app named a relative root, which is a prefix of no absolute
path the Bun plugin hands the loader, so classification fell back to the
absolute path and the /app/ segment won again. Found in review of #528.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: developerz-ai/ultimate/.coderabbit.yml Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthrough
ChangesStylesheet root resolution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Relative app roots now classify absolute stylesheet paths as intended. No actionable merge-blocking risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
CodeRabbit found this in its review of #528, and it checks out.
loadApp('.')run from/appnames a relative root. The Bun plugin hands the loader absolute paths, and no absolute path starts with a relative root, so classification fell back to reading the absolute path and the leading/app/segment won again.setStylesheetRootnow resolves the root against the working directory. A new test inmodule-loader.test.tsnames a relative rootappand failed before the fix.bun run verify: 14/20 passed, 6 skipped.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit