Repository navigation
Conversation
…3 is missing On Omarchy 4.5 the battery on my lock screen showed the old level after a wake and took 8 to 13 seconds to catch up. Patch 0023 for 4.0.6 passes wakeSerial, blankSerial and displayDark into the LockView in Service.qml. The 4.5 version of 0023 doesn't have those 3 lines, so the lock view never knows the screen went dark or woke up. I added them back. Tested on my Pixel 7 Pro. Before, the lock didn't read the battery on wake. With the 3 lines it reads it right away and the level is right as soon as the screen lights. Also added a check for the 3 lines to test/port45.py since the one in test/patches.py only runs for 4.0.6. Assisted-by: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The battery on my lock screen was showing the old level after a wake and took a while to catch up. I saw 8 and 13 seconds. One time it said 60%-ish after an hour on the charger, and when I unlocked it the bar said 90%.
Patch 0023 for 4.0.6 has these 3 lines in Service.qml at the lock surface's
LockView. The 4.5 version of 0023 doesn't:The service still sets all three but the lock view never gets them, so
LockBatterythinks the screen is always lit and never sees a wake. I think they got lost in the 4.5 port (#471).lock_glance()intest/patches.pychecks for them but the 4.5.0 path returns before it runs.I added the lines back to the 4.5
0023and added a check for them totest/port45.py. The check fails on main and passes with this.How I tested: phone unplugged and asleep for about 2 hours, woke it with the power button. I had an audit rule on
execveof/usr/bin/timeoutto see when the lock reads the battery, and a script logging/sys/class/power_supply5 times a second.PM: suspend exitThose two runs were with the 3 lines added by hand to the installed Service.qml (0.1.47). After that I put the original file back, installed this branch's 0.1.49 with
tools/phone-install-package, restarted the shell and did it once more on the charger. Asleep 30 minutes, 69% before and 85% after. The lock read the battery 0.2 s afterPM: suspend exitand showed 85% as soon as it lit.Device and build
uname -r): 7.3.0-rc6-omamobile-gda171eae4cb7Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: omamobile-omarchy, with the omarchy 4.5.0-3 aarch64 package)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-install-packagetook it from 0.1.47 to 0.1.49, the hook reported 29 applied and 1 file changed, andomamobile-omarchy-patches verifyis ok. The Service.qml it left is the same file byte for byte as the hand edited one I tested first.My phone is on Wi-Fi with a sudo user, not root over USB, so I ran
phone-install-packageandphone-smokewithPHONE_SSHset to a small wrapper that doesssh+sudo.The two not ok rows in the report:
omamobile-modem.servicewas already failed on this phone before this change, and the other is Wi-Fi driver lines in dmesg.Not tested:
omarchy update. I usedtools/phone-install-package.tools/phone-smokereportphone-smoke: cheetah
Kernel
7.3.0-rc6-omamobile-gda171eae4cb7, tools at17f9a3c, 2026-11-19T01:43Z.Packages: hyprland 0.57.0-3.3, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.3-1, omamobile-audio 0.5.18-1, omamobile-boot-update 0.1.0-1, omamobile-device-cheetah 0.1.60-1, omamobile-fingerprint 0.1.17-1, omamobile-firstboot 0.1.6-1, omamobile-gnss 0.2.10-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.26-1, omamobile-modem-sit 0.3.43-1, omamobile-omarchy 0.1.49-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-settings 0.1.2-1, omamobile-shell 0.2.132-1, omamobile-voice 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1