Skip to content

omamobile-omarchy 0.1.49: add the 3 lock view lines the 4.5 patch 0023 is missing - #920

Open
iamteedoh wants to merge 1 commit into
derekross:mainfrom
iamteedoh:omarchy45-lock-wake
Open

iamteedoh wants to merge 1 commit into
derekross:mainfrom
iamteedoh:omarchy45-lock-wake

Conversation

@iamteedoh

Copy link
Copy Markdown

What and why

The battery on my lock screen was showing the old level after a wake and took a while to catch up. I saw 8 and 13 seconds. One time it said 60%-ish after an hour on the charger, and when I unlocked it the bar said 90%.

Patch 0023 for 4.0.6 has these 3 lines in Service.qml at the lock surface's LockView. The 4.5 version of 0023 doesn't:

wakeSerial: root.wakeSerial
blankSerial: root.blankSerial
displayDark: root.displayDark

The service still sets all three but the lock view never gets them, so LockBattery thinks the screen is always lit and never sees a wake. I think they got lost in the 4.5 port (#471). lock_glance() in test/patches.py checks for them but the 4.5.0 path returns before it runs.

I added the lines back to the 4.5 0023 and added a check for them to test/port45.py. The check fails on main and passes with this.

How I tested: phone unplugged and asleep for about 2 hours, woke it with the power button. I had an audit rule on execve of /usr/bin/timeout to see when the lock reads the battery, and a script logging /sys/class/power_supply 5 times a second.

before with the 3 lines
sysfs after resume 89% at 0.33 s (was 99% before sleep) 71% at 0.32 s (was 83% before sleep)
lock's battery read on wake none 0.25 s after PM: suspend exit
next reads 5.7 s and 8.9 s after the wake, the old 15 s timers still going every 14.4 s from the wake read
reads while dark timer kept running until suspend none
what I saw 99%, then 88% about 13 s later 71% as soon as it lit

Those two runs were with the 3 lines added by hand to the installed Service.qml (0.1.47). After that I put the original file back, installed this branch's 0.1.49 with tools/phone-install-package, restarted the shell and did it once more on the charger. Asleep 30 minutes, 69% before and 85% after. The lock read the battery 0.2 s after PM: suspend exit and showed 85% as soon as it lit.

Device and build

  • Phone: Pixel 7 Pro (cheetah), release 2026.11.15, Omarchy 4.5.0-3
  • Kernel release (uname -r): 7.3.0-rc6-omamobile-gda171eae4cb7
  • Packages changed, with versions: omamobile-omarchy 0.1.49

Checks (no phone needed)

  • tools/pr-check origin/main passes
  • tests/all passes
  • tests/packages passes (or the packages I touched: omamobile-omarchy, with the omarchy 4.5.0-3 aarch64 package)
  • Each changed package has its version bumped, and the new version is in the commit subject
  • Commits have area prefixes and bodies that say why; any AI help is a Co-Authored-By: or Assisted-by: trailer, never a Signed-off-by:

On the phone

  • I ran this on my own phone, booted into this build
  • Runbook steps passed (plan, step, result): none, there's no plan for this one
  • What I did not test: see below
  • Nothing in this change writes outside slot B and userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)

tools/phone-install-package took it from 0.1.47 to 0.1.49, the hook reported 29 applied and 1 file changed, and omamobile-omarchy-patches verify is ok. The Service.qml it left is the same file byte for byte as the hand edited one I tested first.

My phone is on Wi-Fi with a sudo user, not root over USB, so I ran phone-install-package and phone-smoke with PHONE_SSH set to a small wrapper that does ssh + sudo.

The two not ok rows in the report: omamobile-modem.service was already failed on this phone before this change, and the other is Wi-Fi driver lines in dmesg.

Not tested:

  • getting 0.1.49 through omarchy update. I used tools/phone-install-package.
  • the other things on the 4.5 lock that use these 3 (the glance coming back when the screen goes dark or wakes, a touch on a dark screen only waking it, the wake guard, the media ticker). I only measured the battery.
  • a double tap wake with the fix. All my measured wakes were the power button.
  • 4.0.6, didn't touch it
tools/phone-smoke report

phone-smoke: cheetah

Kernel 7.3.0-rc6-omamobile-gda171eae4cb7, tools at 17f9a3c, 2026-11-19T01:43Z.

Check Result Detail
boot (required) ok kernel 7.3.0-rc6-omamobile-gda171eae4cb7, slot b, up 38606s
storage guard (required) ok 55 partitions; only userdata and slot b's boot images writable
root (required) ok ext4 on userdata, 437G free
kernel health (required) ok no oops or BUG; 0 WARN, 41 error lines in dmesg (39 known, of them UFS dme-set 0x4021 (s2idle) x1, 2 new)
new dmesg errors not ok N N: brcmf_notify_escan_complete: Scan abort failed x1; N N: brcmf_fil_cmd_data: bus is down. we have nothing to do. x1
systemd units not ok failed: omamobile-modem.service
USB gadget (required) ok bound to 11210000.usb
display ok card2-DSI-1 connected, 1440x3120
GPU ok render node on panthor
session (required) ok Hyprland and the Omarchy shell running
lock ok PAM file present, the shell can lock (passwordPam true, locked true)
touch ok Synaptics TouchComm Touchscreen
buttons ok gpio-keys
Wi-Fi ok wlp1s0 on brcmfmac, link up
Bluetooth ok hci0, powered true
battery ok 86% Charging, 30 °C
sound cards ok googleaocsndcar
sensors ok Accelerometer AmbientLight Proximity
cameras skip no libcamera tools
thermal ok hottest zone 53 °C

Packages: hyprland 0.57.0-3.3, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.3-1, omamobile-audio 0.5.18-1, omamobile-boot-update 0.1.0-1, omamobile-device-cheetah 0.1.60-1, omamobile-fingerprint 0.1.17-1, omamobile-firstboot 0.1.6-1, omamobile-gnss 0.2.10-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.26-1, omamobile-modem-sit 0.3.43-1, omamobile-omarchy 0.1.49-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-settings 0.1.2-1, omamobile-shell 0.2.132-1, omamobile-voice 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1

…3 is missing

On Omarchy 4.5 the battery on my lock screen showed the old level after
a wake and took 8 to 13 seconds to catch up.

Patch 0023 for 4.0.6 passes wakeSerial, blankSerial and displayDark into
the LockView in Service.qml. The 4.5 version of 0023 doesn't have those
3 lines, so the lock view never knows the screen went dark or woke up. I
added them back.

Tested on my Pixel 7 Pro. Before, the lock didn't read the battery on
wake. With the 3 lines it reads it right away and the level is right as
soon as the screen lights.

Also added a check for the 3 lines to test/port45.py since the one in
test/patches.py only runs for 4.0.6.

Assisted-by: Claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant