Repository navigation
Conversation
…3 is missing On Omarchy 4.5 the battery on my lock screen showed the old level after a wake and took 8 to 13 seconds to catch up. Patch 0023 for 4.0.6 passes wakeSerial, blankSerial and displayDark into the LockView in Service.qml. The 4.5 version of 0023 doesn't have those 3 lines, so the lock view never knows the screen went dark or woke up. I added them back. Tested on my Pixel 7 Pro. Before, the lock didn't read the battery on wake. With the 3 lines it reads it right away and the level is right as soon as the screen lights. Also added a check for the 3 lines to test/port45.py since the one in test/patches.py only runs for 4.0.6. Assisted-by: Claude
After a wake the clock on my lock screen was still showing the time from before the phone slept. I saw it take about 20 seconds to catch up. It depends on when in the minute the phone went to sleep, so it can be up to a minute. Quickshell's SystemClock waits for the next minute on a timer, and that timer doesn't count while the phone is asleep. So after a wake it keeps the old time until what was left of that minute runs out. New patch 0032 turns the lock's clock off while the screen is dark and back on at a wake. Turning it on makes it read the time right away. It needs displayDark from 0023, so this goes on top of derekross#920. Tested on my Pixel 7 Pro. The lock showed the right time as soon as it lit. The top bar still had the old time for about 45 seconds after I unlocked, since this only fixes the lock. Assisted-by: Claude
Author
|
One question for the reviewers about the other clocks. The top bar, the home clock widget and quick settings use the same I see two ways to fix it:
The agenda widget uses hour precision, so by the same code it could be off for a lot longer. I haven't measured that one. Which way would you want it, or something else? I'm happy to work on it if that's ok with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This goes on top of #920. It needs
displayDarkto reach the lock view, so the first commit here is that one.After a wake the clock on my lock screen was still showing the time from before the phone slept, then caught up some seconds later. I saw about 20 seconds. I also saw it on the top bar and the home clock widget after unlocking.
The lock's clock is Quickshell's
SystemClockwith minute precision. In Quickshell'ssrc/core/clock.cppit sets the time and then starts one timer for the milliseconds left until the next minute. That timer doesn't count while the phone is asleep, so after a wake the clock keeps the old time until what was left of that minute runs out. That can be up to 60 seconds.New patch
0032turns the glance's clock off while the screen is dark and back on at a wake:Turning it on makes
SystemClockread the time right away.How I tested: I ran a second Quickshell on the phone with nothing but a minute precision
SystemClockthat logs every tick next to the real time. That one has no fix, so it shows what the clock does on its own.This only fixes the lock. The bar, the home clock widget and quick settings use
SystemClocktoo and are still late after an unlock. Those have no wake signal to hang this on, so I left them alone. I can open an issue for that with the numbers if that helps.Device and build
uname -r): 7.3.0-rc6-omamobile-gda171eae4cb7Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: omamobile-omarchy, with the omarchy 4.5.0-3 aarch64 package)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-install-packagetook it from 0.1.49 (#920's build) to 0.1.50, the hook reported 30 applied and 1 file changed, andomamobile-omarchy-patches verifyis ok. Same as in #920, my phone is on Wi-Fi with a sudo user, so I ranphone-install-packageandphone-smokewithPHONE_SSHset to a smallssh+sudowrapper.The not ok row in the report is
omamobile-modem.service, which was already failed on this phone before this change.I added a test for the clock to
test/lock-glance.qml(it skips on a family without 0032) and a check totest/port45.py. One thing I ran into:test/lock-glanceisn't run on the 4.5 path, and when I ran it by hand against the patched 4.5 filestest_computer_lock_unchangedfails. It fails the same way without this patch, so it's not from this change. I didn't look into why.Not tested:
omarchy update. I usedtools/phone-install-package.tools/phone-smokereportphone-smoke: cheetah
Kernel
7.3.0-rc6-omamobile-gda171eae4cb7, tools atbf06e8f, 2026-11-19T03:09Z.Packages: hyprland 0.57.0-3.3, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.3-1, omamobile-audio 0.5.18-1, omamobile-boot-update 0.1.0-1, omamobile-device-cheetah 0.1.60-1, omamobile-fingerprint 0.1.17-1, omamobile-firstboot 0.1.6-1, omamobile-gnss 0.2.10-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.26-1, omamobile-modem-sit 0.3.43-1, omamobile-omarchy 0.1.50-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-settings 0.1.2-1, omamobile-shell 0.2.132-1, omamobile-voice 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1