Repository navigation
hyprland 0.57.0-3.4: send wl_output's geometry after a rotation - #785
angelrenefm wants to merge 1 commit into
Conversation
|
Thank you, Ángel. The landscape keyboard covering the whole screen had a satisfyingly small cause: a transform-only rule never runs I checked it against the 0.57.0 release: the sums match and all six patches apply with It changes what every client hears after a rotation on every phone, so I'll run it on my Pixel 7 Pro before merging, in one build with #762, #753 and #786. In that order this one goes third, as 0.57.0-3.6 with the patch renamed |
…ekross#785's patch Review of derekross#753: the AGENTS.md gotcha's last sentence (no rule change applies while the display is off) was only seen in the VM, and says so now. The README's note on dropping 0003 names derekross#785's wl_output patch, the same cause one protocol over, so the two are looked at together once upstream fixes it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A rotation changes the transform but not the mode, so Hyprland sent wl_output.done without a new wl_output.geometry: clients bound before the rotation kept the old transform. squeekboard, bound at login, then sized itself for portrait in landscape and covered the whole screen (apps that open the keyboard were left -18 px tall on a Pixel 7). 0003 makes every wl_output done carry the whole state (scale, mode, geometry with the transform), which updateState already sends on a mode change. On the Pixel 7: a client bound before a quarter turn now gets geometry with transform 1, and 0 on the way back (before: done only, transform stayed 0). Chromium in landscape with the keyboard up is 107 px tall at squeekboard's default horizontal scale (before: -18), and the horizontal scale setting takes effect again (134 px at 0.85, 161 at 0.7). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ff21ac4 to
d80a0dc
Compare
|
I've added the |
|
Thank you, Ángel, for adding the trailer. The tree is unchanged, so nothing about the review moves. I've now applied this together with the other three open Hyprland changes in every order they could merge, and every order gives the same compositor, so it goes in third as 0.57.0-3.6 with the patch renamed |
What and why
On a Pixel 7 turned to landscape, the on-screen keyboard covered the whole screen. Apps that open it at start (Chromium, Messages, Contacts…) were left -18 px tall, so nothing of them showed.
The cause is in Hyprland 0.57, and it is the same one #753 found for the lock screen. A monitor rule that only changes the transform goes through
CMonitor::applyMonitorRuleSoft()and emits nomodeChanged.CWLOutputResource::updateState()only runs onmodeChanged, so clients bound before the turn get awl_output.done(from xdg-output's update) but no newwl_output.geometry, and keep the old transform. squeekboard binds at login, so it kept believing the screen was in portrait. It sized itself with the vertical formula and our 1.45 vertical scale, and its horizontal scale setting had no effect.0003-output-send-the-whole-state-with-done.patchmakesCWLOutputProtocol::sendDone()send each resource's whole state (scale, mode, geometry with the transform), which ends with the done. That is whatupdateState()already sent on a mode change, and sending the same values again is allowed by the protocol. The bug is still in Hyprlandmain(src/protocols/core/Output.cpp).Tested
On my Pixel 7, with the package built on the phone (
makepkg,-j4) and installed withpacman -U, after a logout:done, and the transform stayed 0. With the patch, the client getsgeometrywith transform 1, and 0 on the way back.tools/pr-checkpasses.Notes
Output.cpphere, the session lock and the input method there), so they stack. I'll renumber after whichever goes in first, or leave the number to you.I used AI help (Claude) to work on this.