Repository navigation
Conversation
…ekross#522) A phone locked on its side, or turned as it locked, kept a squeezed lock screen until it was unlocked: the clock narrow and tall, touch off its targets. omamobile-autorotate turns a locked screen back to portrait within its one-second poll, after the lock surface exists, and the lock surface never heard of that turn. Hyprland 0.57 applies a monitor rule that differs from the active one only in the transform through CMonitor::applyMonitorRuleSoft(), which resizes the monitor without emitting modeChanged, and a session-lock surface was sent a configure on that event alone. 0003 has the lock surface follow the monitor layout as well, as xdg_output does, and send a configure when the monitor's size is no longer the one it last sent. pkgrel 3.4. tools/lock-turn-test checks it on a phone: a bare lock client, a quarter turn and back with a transform-only rule change, the lock surface's size against the monitor's. It needs no root, the client opens by itself, and the monitor is turned back on exit. Tested: lock-turn-test fails on a Pixel 9a with 0.57.0-3.3 (monitor 909x405, lock surface 405x909) and passes three times with 0.57.0-3.4; the same in a VM with the 9a's packages (3.1 fails, 3.4 passes, also with OMAMOBILE_ROTATION_HOLD=1). Omarchy's lock on the 9a with 3.4, locked in landscape and turned to portrait, is drawn at 405x909 (read back with kmsgrab). All six patches apply with --fuzz=0. Not run on the Pixel 7 Pro or the Pixel 7. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Thank you, den-kloot. This is a very good piece of work: you found that the lock wasn't the problem, that a transform-only rule goes through I checked it against the 0.57.0 release: the sums match and all six patches apply with Since it changes the lock on every phone and hasn't run on a Pixel 7 Pro yet, I'll run it on mine before merging, in one build with the other three, so the phone only needs one Hyprland install. In that order this one goes second, as 0.57.0-3.5 with the patch renamed Three small things, none needed for the merge:
|
…ekross#785's patch Review of derekross#753: the AGENTS.md gotcha's last sentence (no rule change applies while the display is off) was only seen in the VM, and says so now. The README's note on dropping 0003 names derekross#785's wl_output patch, the same cause one protocol over, so the two are looked at together once upstream fixes it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Thank you for checking it against the release and against the other three.
The description says "Part of #522" now, so the issue keeps the second or two of landscape after a lock taken on its side. Renaming the patch to |
|
Thank you, den-kloot, all three are in exactly as I'd hoped: "Part of #522" keeps the issue for the second or two of landscape, the gotcha now says it's from a VM, and the README points at #785's patch. I've now applied this together with the other three open Hyprland changes in every order they could merge, and every order gives the same compositor, so the numbering really is just bookkeeping. I'll do the rename to 0.57.0-3.5 and |
What and why
Part of #522: a phone locked on its side, or turned as it locked, kept a squeezed lock screen until it was unlocked (the clock narrow and tall, the PIN pad's touch off its targets).
The cause is in Hyprland 0.57, not in the lock or in autorotate:
CMonitor::applyMonitorRuleSoft()(CMonitorRuleManager::ensureMonitorStatus(),COMPARISON_SOFT_MISMATCH). The monitor gets its turned size and the layout is arranged again, butmodeChangedis not emitted.CSessionLockSurfacesendsext_session_lock_surface_v1.configureonly onmodeChanged. So a lock surface never hears of a quarter turn: the client keeps drawing at the old size and the renderer stretches that buffer over the turned output.omamobile-autorotateturns a locked screen back to portrait within its one-second poll, which is after the lock surface exists, with exactly such a rule change.Hyprland's main branch had the same gap on 2026-11-13.
The change:
packages/hyprland0003 (src/protocols/SessionLock.cpp,.hpp, about 15 lines): the lock surface also follows the monitor layout, asxdg_outputdoes, and sends a configure when the monitor's size is no longer the one it last sent. pkgrel 3.4.The test:
tools/lock-turn-test, run on the phone as the session's user. It locks for about five seconds with a bare lock client of its own (Quickshell, one surface that reports its size), turns the monitor a quarter and back with a rule change in which only the transform differs, and compares the lock surface's size with the monitor's. No root. The client opens by itself after 20 s whatever happens to the script, the monitor is turned back on exit (also after Ctrl-C or a hang-up), and--unlockopens a lock a killed run left behind.Two things that hid the cause for a while, now in AGENTS.md:
2.6666667against an active2.66667takes the full path and does send a configure, so the first turn of an experiment can look fine. The test applies its own rule once before it locks.Device and build
uname -r): 7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78Built from this PKGBUILD in an Arch Linux ARM container on an aarch64 host (
-j8, 6 min), againstextra's aquamarine 0.16.0, hyprgraphics 0.6.0 and hyprutils 0.14.3 (libaquamarine.so=15,libhyprgraphics.so=5, as the phone has). The binary on the phone was built before I reworded the patch's description; the diff is the same, and the final files passmakepkg -o(checksums, all six patches with--fuzz=0).Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpasses (onlytests/tools-helprun: it passes with the new tool)tests/packagespasses (not run:packages/hyprlandhas notest/all, no other package is touched)versionbumped, and the new version is in the commit subject (pkgrel 3.4)Co-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
tools/lock-turn-test, a quarter turnOMAMOBILE_ROTATION_HOLD=1WAYLAND_DEBUG=1on a lock client in the VM: 3.1 sends oneconfigure(405, 909)at the lock and none for four quarter turns, whilezxdg_output_v1.logical_sizefollows each; 3.4 sends a configure with the new size after each quarter turn.ffmpeg -f kmsgrab, since screencopy shows a locked screen black). On the 9a with 3.3: turned to landscape and back while locked, the surface stayed 909x405 and was drawn squeezed into the portrait screen. On the 9a with 3.4: locked in landscape, then turned to portrait, it is drawn at 405x909, and a swipe on it opens it.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)Not in this change: with 3.4 a phone locked on its side still shows the lock in landscape for up to a second or two before autorotate's poll turns it; it is then drawn right. Having the lock ask autorotate for portrait before it makes its surfaces would remove that.
tools/phone-smokereportphone-smoke: unknown
Kernel
7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78, tools atunknown, 2026-11-14T05:28Z.Packages: hyprland 0.57.0-3.4, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.3-1, omamobile-audio 0.5.18-1, omamobile-device-tegu 0.2.18-1, omamobile-firstboot 0.1.5-1, omamobile-gnss 0.2.9-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.21-1, omamobile-modem-sit 0.3.35-1, omamobile-omarchy 0.1.44-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-settings 0.1.2-1, omamobile-shell 0.2.127-1, omamobile-voice 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1
🤖 Generated with Claude Code