Repository navigation
omamobile-shell 0.2.32: the NFC tile really switches NFC - #78
Conversation
|
Thanks, the diagnosis is right: on my Pixel 7 Pro the tile's "Off" has been a no-op for the same reason, and neard is never told when the kernel takes the radio down. The gate and the package test pass. Two things need changing before this can go in, one of them because of how systemd treats the service's own unit.
Then kernel #71 lands right after this one, since each is only half a fix without the other (without #71 the block leaves neard polling; without this the unblock powers nothing), and I'll run one block/unblock cycle on the Pixel 7 Pro before calling it done. The kernel release ( |
7d43824 to
077a729
Compare
|
You're right, thanks for reproducing it. Pushed, rebased onto main after #64:
The kernel release for the interrupt counts is in the description. |
|
Thanks, this is exactly the fix. I re-ran my two-unit test with your new unit line. With I'm sorry, but one thing moved under you: my touch batch 4 (#90) landed today as |
The tile blocks NFC through rfkill, but neard isn't told when the kernel takes the radio down, and the kernel refused to take it down at all while polling (kernel PR derekross#71). Now omamobile-nfc-open follows the rfkill switch: a block powers the adapter off through neard, an unblock restarts neard so it powers the adapter again and polling resumes, and the service starts from a fresh neard. The service pulls neard in with Wants=, not Requires=: with Requires= its own neard restart would restart it too, and the new instance would restart neard again, until neard hit its start limit. The package test fails if Requires=neard comes back.
077a729 to
2470280
Compare
|
No problem. It's 0.2.32 now, in the title and the commit, rebased onto today's main after your #90. The shell package test passes. |
|
Thanks for the quick bump. 0.2.32 is free (main is on 0.2.30 and my next batch on 0.2.31), and nothing else changed since I last looked. On the branch merged onto today's main, the gate and the shell package's tests pass, and my two-unit test gives the same result as before. I'm merging this now. Next I'll put kernel #71 on my Pixel 7 Pro and run the tile check, and merge #71 after it. |
On the palmtop, the NFC tile's "off" left the radio polling. There were two reasons:
omamobile-nfc-opennow follows NFC's rfkill switch. On a block it powers the adapter off through neard. On an unblock it restarts neard, which finds the adapter again, powers it (DefaultPowered), and polling resumes. The service also starts from a fresh neard, so a stale view from before it ran can't leave NFC unpowered.Tested on the palmtop with the fixed nfc.ko. I counted the controller's interrupts over 5 s after each step: about 65 while polling, 0 when blocked, polling again after each unblock. That held over three block and unblock cycles and a restart of the service. I tested only with #71 applied. Without it, the block depends on neard stopping its own poll when it powers the adapter off, which I haven't verified.
test/allgained two checks. Locally, everything passes except the known Switcher.qml parse on a laptop whose qmlformat is Qt 5's (#67).tools/pr-checkpasses.Kernel for the counts above:
7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirtyon the Pixel 9a (the integration kernel, with kernel #71).