Repository navigation
docs/review: 25 lessons and one correction from the twentieth round - #84
Merged
Merged
Conversation
The round covered the gs201 sibling ports, the Pixel 9a's kernel, camera, NFC and userspace series, the Pixel 6 Pro port and issue #77, and the contributor-key, release and husky PRs. C-7 corrects L-135's pd_ignore_unused proxy, which of_genpd_sync_state defeats on 7.3. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The candidate lessons from round 20 (the pull requests and issues reviewed on 2026-10-27), drafted into LESSONS.md for the maintainer to confirm: 25 new entries (L-168 to L-192) under their areas, and correction C-7 with L-135 fixed in place (round 12's
pd_ignore_unusedsuggestion could not answer the warm-reset question on 7.3, becauseof_genpd_sync_state()powers unused domains off regardless; the observable is each domain'sactive_time).Merged across groups: the duplicate-of-a-rebase-merged-commit check (L-182), "I took the point" checked by diff (L-183). Dropped as restatements: the action_required note (L-59 already), the force-push constraint (L-166 already), the #78/#64 version collision (L-12 applied).
🤖 Generated with Claude Code