Repository navigation
phone-demo: the demo notifications on Omarchy 4.5's store too - #686
Merged
Merged
Conversation
On Omarchy 4.5 the notification service keeps the toasts on screen in live.json and the closed ones in history.json, rows with a key, where 4.0 kept one file per notification. phone-demo still looked for 4.0's files, so on a 4.5 phone (the Pixel 7 Pro since 2026-11-11): - notify and clear found no demo notifications to take away, so the demo's toasts stayed in the shade and on the lock glance after clear, against the tool's promise to remove exactly what it added; - the Do Not Disturb warning never fired (it read notifications.json; 4.5 keeps the state in quiet.json); - restore-notes copied a backup's 4.0 history/ and images/ directories into a store that never reads them. The tool now tells the layouts apart the way the shade does (history.json is there from the 4.5 service's first start). On 4.5 it finds the demo's rows by key and takes them away through Omarchy's own forget call; only when the shell doesn't answer does it rewrite the two files itself. It counts rows that are still there instead of reporting them gone, reads Do Not Disturb from quiet.json, and copies nothing from a backup into a 4.5 store. 4.0 behaves as before. tests/phone-demo-notes runs the tool's phone side against both layouts in a made-up home. Not run on a phone: seed and clear change what the phone shows, and wait for the maintainer. Found by the round 52 review of #482. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
derekross
force-pushed
the
phone-demo-45-store
branch
from
November 12, 2026 04:45
2ca132c to
7fc4db8
Compare
5 of 9 tasks
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…oss#686) On Omarchy 4.5 the notification service keeps the toasts on screen in live.json and the closed ones in history.json, rows with a key, where 4.0 kept one file per notification. phone-demo still looked for 4.0's files, so on a 4.5 phone (the Pixel 7 Pro since 2026-11-11): - notify and clear found no demo notifications to take away, so the demo's toasts stayed in the shade and on the lock glance after clear, against the tool's promise to remove exactly what it added; - the Do Not Disturb warning never fired (it read notifications.json; 4.5 keeps the state in quiet.json); - restore-notes copied a backup's 4.0 history/ and images/ directories into a store that never reads them. The tool now tells the layouts apart the way the shade does (history.json is there from the 4.5 service's first start). On 4.5 it finds the demo's rows by key and takes them away through Omarchy's own forget call; only when the shell doesn't answer does it rewrite the two files itself. It counts rows that are still there instead of reporting them gone, reads Do Not Disturb from quiet.json, and copies nothing from a backup into a 4.5 store. 4.0 behaves as before. tests/phone-demo-notes runs the tool's phone side against both layouts in a made-up home. Not run on a phone: seed and clear change what the phone shows, and wait for the maintainer. Found by the round 52 review of derekross#482. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the round 52 review of #482.
Omarchy 4.5 keeps the toasts on screen in
live.jsonand the closed ones inhistory.json, rows with a key; 4.0 kept one file per notification.tools/phone-demostill looked for 4.0's files, so on a 4.5 phone:notifyandclearfound nothing to take away, so the demo's toasts stayed in the shade and on the lock glance afterclear;quiet.json);restore-notescopied a backup's 4.0history/andimages/into a store that never reads them.Now
history.jsonis there from the 4.5 service's first start).forget; the files are rewritten directly only when the shell doesn't answer.quiet.json; nothing from a backup is copied into a 4.5 store.tests/phone-demo-notes(new, intests/all) runs the tool's phone side against both layouts in a made-up home: 13 checks.Not run on a phone.
seed,notifyandclearchange what the phone shows and send toasts, so that run waits for the maintainer.🤖 Generated with Claude Code