Skip to content

phone-demo: the demo notifications on Omarchy 4.5's store too - #686

Merged
derekross merged 1 commit into
mainfrom
phone-demo-45-store
Nov 12, 2026
Merged

derekross merged 1 commit into
mainfrom
phone-demo-45-store

Conversation

@derekross

Copy link
Copy Markdown
Owner

Found by the round 52 review of #482.

Omarchy 4.5 keeps the toasts on screen in live.json and the closed ones in history.json, rows with a key; 4.0 kept one file per notification. tools/phone-demo still looked for 4.0's files, so on a 4.5 phone:

  • notify and clear found nothing to take away, so the demo's toasts stayed in the shade and on the lock glance after clear;
  • the Do Not Disturb warning never fired (4.5 keeps that state in quiet.json);
  • restore-notes copied a backup's 4.0 history/ and images/ into a store that never reads them.

Now

  • The two layouts are told apart the way the shade does it (history.json is there from the 4.5 service's first start).
  • On 4.5 the demo's rows are found by key and taken away through Omarchy's own forget; the files are rewritten directly only when the shell doesn't answer.
  • Rows still there afterwards are counted in the message, not reported as gone.
  • Do Not Disturb is read from quiet.json; nothing from a backup is copied into a 4.5 store.
  • 4.0 behaves as before.

tests/phone-demo-notes (new, in tests/all) runs the tool's phone side against both layouts in a made-up home: 13 checks.

Not run on a phone. seed, notify and clear change what the phone shows and send toasts, so that run waits for the maintainer.

🤖 Generated with Claude Code

On Omarchy 4.5 the notification service keeps the toasts on screen in
live.json and the closed ones in history.json, rows with a key, where 4.0
kept one file per notification. phone-demo still looked for 4.0's files,
so on a 4.5 phone (the Pixel 7 Pro since 2026-11-11):

- notify and clear found no demo notifications to take away, so the
  demo's toasts stayed in the shade and on the lock glance after clear,
  against the tool's promise to remove exactly what it added;
- the Do Not Disturb warning never fired (it read notifications.json;
  4.5 keeps the state in quiet.json);
- restore-notes copied a backup's 4.0 history/ and images/ directories
  into a store that never reads them.

The tool now tells the layouts apart the way the shade does (history.json
is there from the 4.5 service's first start). On 4.5 it finds the demo's
rows by key and takes them away through Omarchy's own forget call; only
when the shell doesn't answer does it rewrite the two files itself. It
counts rows that are still there instead of reporting them gone, reads
Do Not Disturb from quiet.json, and copies nothing from a backup into a
4.5 store. 4.0 behaves as before.

tests/phone-demo-notes runs the tool's phone side against both layouts
in a made-up home. Not run on a phone: seed and clear change what the
phone shows, and wait for the maintainer.

Found by the round 52 review of #482.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit 04d8017 into main Nov 12, 2026
2 checks passed
@derekross
derekross deleted the phone-demo-45-store branch November 12, 2026 04:55
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…oss#686)

On Omarchy 4.5 the notification service keeps the toasts on screen in
live.json and the closed ones in history.json, rows with a key, where 4.0
kept one file per notification. phone-demo still looked for 4.0's files,
so on a 4.5 phone (the Pixel 7 Pro since 2026-11-11):

- notify and clear found no demo notifications to take away, so the
  demo's toasts stayed in the shade and on the lock glance after clear,
  against the tool's promise to remove exactly what it added;
- the Do Not Disturb warning never fired (it read notifications.json;
  4.5 keeps the state in quiet.json);
- restore-notes copied a backup's 4.0 history/ and images/ directories
  into a store that never reads them.

The tool now tells the layouts apart the way the shade does (history.json
is there from the 4.5 service's first start). On 4.5 it finds the demo's
rows by key and takes them away through Omarchy's own forget call; only
when the shell doesn't answer does it rewrite the two files itself. It
counts rows that are still there instead of reporting them gone, reads
Do Not Disturb from quiet.json, and copies nothing from a backup into a
4.5 store. 4.0 behaves as before.

tests/phone-demo-notes runs the tool's phone side against both layouts
in a made-up home. Not run on a phone: seed and clear change what the
phone shows, and wait for the maintainer.

Found by the round 52 review of derekross#482.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant