Repository navigation
tools: the chroot extractors say build.prop can't be read, not that there is none - #676
Conversation
…here is none When the copy of the vendor partition's build.prop failed (a full work directory, say: debugfs then prints "No space left on device", exits 0 and leaves an empty file), extract-vendor-chroot and extract-fingerprint-vendor said "vendor.img has no build.prop" although the file was in the image. They now say "build.prop can't be read from vendor.img", as extract-vendor-firmware does since derekross#663, which is true whether the file is missing, empty or not copied. Unlike that tool they offer no override: -f skips only the device checks, so the message promises none, and the run still stops. tests/chroot-extractors is new (neither tool had a test): stand-ins for unzip and debugfs fail the copy as real debugfs does on a full disk, and each tool must say the new words. With main's tools both checks fail. Tested: the new test, tests/all and tools/pr-check origin/main, and both tools on a real ext4 vendor image holding build.prop, with the host's debugfs and the work directory on a full tmpfs. Not tested: a real factory image, and EROFS images, which both tools refuse before this line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, @only21mil. This is the follow-up I had in mind on #663: the three extractors now speak alike, and you were right to leave "; use -f to override" out here, since I checked it merged onto today's main. With the conflict below resolved, One thing before I can merge: the branch conflicts with main in For some later change, not this one: both tools still throw away debugfs's own message, so the reader learns that the read failed but not why (in your reproduction, "No space left on device"). Passing its last line on in the error would close that. |
The only conflict was the end of tests/all: both suites are kept there, tests/phone-demo-notes and then tests/chroot-extractors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note 🤖 Opus 5.5 replying on behalf of Victor. I merged main into the branch with one merge commit instead of rebasing, so the head moved from 80e07cb, the one you ran, to 77e6975, and no history was rewritten or force-pushed. |
The only conflict was at the end of tests/all: both suites are kept, with tests/chroot-extractors after main's tests/install-guided. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note 🤖 Opus 5.5 replying on behalf of Victor. Main moved again (your #645 appends |
|
Thanks, @only21mil. The conflict is resolved the way I asked, with your suite last, and the two tools and the test are the same bytes as the head I ran. Since then #712 changed the sort lines in both extractors, so I checked the merge again on today's main: it merges cleanly, each tool differs from main by your one message line, Passing debugfs's own message on in its own pull request is fine, as you propose. |
What and why
When
tools/extract-vendor-chrootortools/extract-fingerprint-vendorcan't copy the vendor partition'sbuild.prop, they stop with "vendor.img has no build.prop", also when the file is in the image and only the copy failed. As suggested on #663, both now say "build.prop can't be read from vendor.img", the wordstools/extract-vendor-firmwareuses since then. I left out its "; use -f to override": here-fskips only the device checks, so it wouldn't help. The run still stops.Reproduction: both real tools with the host's debugfs on real ext4 images (made-up files,
mkfs.ext4 -d; vendor 8 MiB, system 4 MiB) in an image zip for cheetah. The one fault: the work directory (-w) is a 12 MiB tmpfs that the two unzipped images fill, so debugfs's copy ofbuild.propfails ("No space left on device", exit 0, an empty file). The runs with room are the control; they get pastbuild.propand stop later because the made-up system image has no runtime APEX. Nothing is trimmed.Before, on main (e163141):
The after capture below was taken on 40178ecf. Both extractor files are byte-identical there, at 80e07cb, the head the maintainer ran, and at the current head c8f0a9e (main merged in again), and re-runs on main 9d7ade2 and on c8f0a9e matched the original captures apart from image timestamps.
Regression test (a stand-in, not the reproduction): the new
tests/chroot-extractors, since neither tool had a test. Stand-ins for unzip and debugfs fail the copy as debugfs does on a full disk, and each tool must print the new words. With main's tools (XVC=,XFP=) both checks fail.Device and build
uname -r): not applicable, no phoneChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none, so not run)versionbumped, and the new version is in the commit subject: no package changedCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
super.imgsources on a full work disk; EROFS images, which both tools refuse before this lineuserdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: laptop tools that never run on a phone (CONTRIBUTING.md §6.5).
Generated with Claude Opus 5.5 in T3 Code Nightly