Repository navigation
extract-vendor-firmware: say build.prop can't be read, not that there is none - #663
Conversation
… is none When the copy of the vendor partition's build.prop fails, the tool said "vendor.img has no build.prop" although the file is in the image: a work directory on a full disk does it, since debugfs then writes an empty build.prop and reports "No space left on device". The message now says "build.prop can't be read from vendor.img", which is true when the file is missing, empty or its copy failed, as suggested on derekross#647. Nothing else changes: the run still stops unless -f is given. Tested: tests/extract-vendor-firmware, with a new case whose build.prop is in the image and whose copy fails (the stand-in debugfs reports a write error); main's tool fails it and the four checks that now expect the new words. By hand, the tool on a real ext4 image in a factory zip, with the work directory on a full 8 MiB tmpfs: main says the image has no build.prop, this branch that it can't be read. Not tested: a Google factory image. extract-vendor-chroot and extract-fingerprint-vendor say the same "has no build.prop" on a full work disk; they are left as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, @only21mil. This is the wording I mentioned on #647, and the reproduction on a full work directory shows well why it matters: the old message sent the reader to the image when the image was fine. I checked it merged onto today's main. For some later change, not this one: Merging. |
|
Note 🤖 Opus 5.5 replying on behalf of Victor. #676 is that PR. Both tools now stop with |
…here is none (#676) When debugfs can't copy the vendor partition's `build.prop` (a full work directory, for one), `tools/extract-vendor-chroot` and `tools/extract-fingerprint-vendor` stopped with "vendor.img has no build.prop", also when the file was there. Both now say "build.prop can't be read from vendor.img", the words `tools/extract-vendor-firmware` uses since #663; `-f` skips only the device checks in these two tools, so the message doesn't offer it. `tests/chroot-extractors` runs both against made-up images with a debugfs that fails the copy.
… is none (derekross#663) When the copy of the vendor partition's `build.prop` failed (a full work directory, say), the tool said "vendor.img has no build.prop" although the file was in the image. It now says "build.prop can't be read from vendor.img", which is true whether the file is missing, empty or not copied; the run still stops unless `-f` is given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What and why
When
tools/extract-vendor-firmwarecan't copy the vendor partition'sbuild.prop, it stops with "vendor.img has no build.prop", also when the file is in the image and only the copy failed. As suggested on #647, it now says "build.prop can't be read from vendor.img", which is true whether the file is missing, empty or not copied. The run still stops unless-fis given.Reproduction: the real tool and the host's debugfs on a real ext4 image (made-up files,
mkfs.ext4 -d) inside a factory image zip for cheetah. The one fault: the work directory (-w) is an 8 MiB tmpfs that the unzipped 8 MiBvendor.imgfills, so debugfs's copy ofbuild.propfails ("No space left on device", exit 0). The second run, with room, is the control. The script drops only the control run's per-file mapping lines.Before, on main (fdd3ab3):
After, on this branch:
Regression test (a stand-in, not the reproduction):
tests/extract-vendor-firmwareadds "a build.prop whose copy fails", where the stand-in debugfs reports a write error forbuild.prop, and its build.prop checks expect the new words. With main's tool (EVF=), those five checks fail.Device and build
uname -r): not applicable, no phoneChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none, so not run)versionbumped, and the new version is in the commit subject: no package changedCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
super.imgsources on a full work disk (the test covers the message for ext4 and EROFS)userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: a laptop tool that never runs on a phone (CONTRIBUTING.md §6.5).
Generated with Claude Opus 5.5 in T3 Code Nightly