Repository navigation
omamobile-shell: open native app search from the Home dock - #612
marselnenaj wants to merge 1 commit into
Conversation
Restore the phone's Ask Agent card and editable in-place conversation. Only explicit Send submits a task. Back returns to Search, Home closes it, and closing or locking cancels active work without reviving stale input. Use the configured provider and its existing account environment. The first native adapter supports Codex with workspace-write; other providers retain an explicit terminal handoff. Keep credentials with the CLI, bind requests and completed conversation identities, acknowledge cancellation/reset and preserve task artifacts. Never enable approval or sandbox bypass flags. Exercise the actual QML/Python transport against inert CLIs, including failed-turn continuity, account changes and local transport recovery. Add Quickshell to CI/check dependencies and include neutral themed screenshots and an actual component recording. Phone acceptance remains outstanding. Depends on the native Search core in derekross#612; allocate the version at merge. Co-Authored-By: Codex <codex@openai.com>
|
Thank you, @marselnenaj. This is careful work: the focus requests are generation-guarded, Search gives its input back before an app or the lock can take it, Back and Home are handled in the shell, the Omarchy focus prime is credited with its licence, and nearly everything visual comes from Commons and the applied theme. I checked the calls you use against the signed Omarchy 4.0.6-1 and 4.5.0-3 packages and they are all there ( Before I can take it:
Three things on the look, where I'd like it to match the rest of the shell:
One decision is mine: whether this is the default tap now or starts as opt-in ( And two questions. |
7ea2e8f to
1b37705
Compare
|
Thanks for the review. The updated Search uses the shell glyphs and existing drawer colors. I removed the review media from the source tree and retained the upstream version. The default remains for you to decide. The static import could prevent Back from loading without the launcher. The optional client now loads only when available. The fixture exercises the full Back component body with inert surface imports and verifies the Escape fallback with no launcher directory, and the shared Search close path with the launcher present. The old strip condition required an open keyboard to suppress the strip on lock. The new condition suppresses it whenever the launcher observes a lock. Since the observation refreshes around keyboard transitions, I haven't verified whether the strip unmaps immediately when a lock starts with the keyboard already hidden. The physical test sequence and smoke report remain pending. I have the refreshed offscreen captures locally and still need to upload them through GitHub's attachment UI. |
|
Thank you, @marselnenaj. The look is where I wanted it: icon-font glyphs, the drawer's surface and scrim, the launcher's secondary ink, no keys of our own, and the review images are out of the tree. Thanks too for the straight answers on what you haven't verified. Main moved under you this afternoon, and that's the main thing now. #643 (omamobile-shell 0.2.117) changed how Back works for the whole phone:
On the decision that's mine: I'd like this to start as opt-in. Please make Small things while you're there: the comment at I'll run it on my Pixel 7 Pro once it's rebased. |
Use the existing app catalog and shell theme for a touch-sized search surface. Leave the current dock tap and App Library as the default. Prime keyboard focus briefly and release Search input on close, app launch, or observed lock. Register Search through the shared Back client. While the keyboard is visible, the first Back dismisses it and the next Back closes Search. Keep the always-mapped Search windows out of Home's covering-layer census and pause Home from the explicit Search state. The native focus prime follows Omarchy's MIT-licensed KeyboardPanel pattern. Keep its attribution in LICENSE.omarchy. Co-Authored-By: Codex <codex@openai.com>
c5d8cff to
934af86
Compare
|
Thank you, @marselnenaj. That was a fast and complete turn: Search registers through Two things in the code, then the phone:
One small thing while you're there: I'll set the version at merge, and I'll run it on my Pixel 7 Pro once the two points are in, with the option off and on. |
Native app Search is an opt-in launcher setting. Turning on
nativeSearchopens the separate app search when tapping the dock. With the default setting, the dock and swipe up still open the App Library and its existing agent flow.Search uses the existing application catalog, drawer palette and shell icon font. It joins the common Back surface list as
app search. Back first dismisses the keyboard and then closes Search. While Search is visible, Home pauses its widgets and yields Back. The two always-mapped Search layers count as screen furniture. The Home strip retains the keyboard-scoped lock condition from main.Verification