Repository navigation
omamobile-shell: add Ask Agent conversations to native Search - #614
marselnenaj wants to merge 4 commits into
Conversation
Separate explicit dock app search from the swipe-driven App Library while retaining the existing catalog and launch path. Allow the previous tap behavior through the nativeSearch setting. Own initial input focus through the attributed Omarchy focus prime, cancel late requests when closing or when a known lock arrives, and close Search through native Back and Home without per-gesture helper processes. Use theme palette, typography, corners and motion tokens. Include neutral light/dark previews and an animated component capture. The full package suite and actual Qt lifecycle tests pass; final dock wording was checked separately. Physical layer-shell and on-screen keyboard acceptance remain outstanding. Co-Authored-By: Codex <codex@openai.com>
Keep the phone search layout when extracting the public app-search view: place the query at the top and use compact icon/name/description rows rather than enclosing each result in a separate bordered card. Show three initial suggestions and retain the existing bounded matching catalog while typing. Paint a shared translucent theme tint once, keep typography and corners configurable, and expose clamped theme alpha overrides. Document optional namespace-scoped compositor blur without changing global blur settings. Replace placeholder-only media with actual light/dark QML captures using original licensed neutral SVG icons and test scenery. Preserve native focus, known-lock cancellation and Back/Home routing. Component tests pass; exact package phone acceptance and physical frame pacing remain outstanding. Co-Authored-By: Codex <codex@openai.com>
Restore the phone's Ask Agent card and editable in-place conversation. Only explicit Send submits a task. Back returns to Search, Home closes it, and closing or locking cancels active work without reviving stale input. Use the configured provider and its existing account environment. The first native adapter supports Codex with workspace-write; other providers retain an explicit terminal handoff. Keep credentials with the CLI, bind requests and completed conversation identities, acknowledge cancellation/reset and preserve task artifacts. Never enable approval or sandbox bypass flags. Exercise the actual QML/Python transport against inert CLIs, including failed-turn continuity, account changes and local transport recovery. Add Quickshell to CI/check dependencies and include neutral themed screenshots and an actual component recording. Phone acceptance remains outstanding. Depends on the native Search core in derekross#612; allocate the version at merge. Co-Authored-By: Codex <codex@openai.com>
43bfdab to
b05222c
Compare
The hosted compact-layout check found a composer extending beyond a 320-pixel viewport. A wider platform font makes the terminal handoff button's preferred width propagate through the action row and composer. Allow actions to shrink between their touch minimum and natural width, and bound/elide their labels while retaining the full accessible name. This leaves unconstrained layouts at their natural button sizes. Reproduce the overflow with an oversized action preference in a temporary conversation, alongside the unchanged compact viewport test. The old implementation fails the new regression; the correction passes all 32 Qt cases. Refresh dark/light previews and include a compact example. Co-Authored-By: Codex <codex@openai.com>
|
Thank you, @marselnenaj. I read the bridge closely, because this is the first part of the shell that would talk to an agent on the user's behalf, and a lot of it is done the way I'd want: it only starts on an explicit Send, it runs the client the user already installed and never a wrapper that could install one, it keeps no credentials or transcript of its own, a lock or a dismissal stops the request, everything is bounded, and replies are plain text. The private per-session folder, opened without following links, is a nice touch. I can't merge it yet, and part of that is a decision I have to make rather than something for you to fix:
Smaller things: the workflow change (Quickshell in the CI container, and as a check dependency) deserves a line of its own in the description, and please confirm the aarch64 package build finds it. Session folders that the agent wrote into are never removed; that's fine for now but should be said in the README as a thing the user may want to clear. |
|
Thank you for the detailed review. I will pause further adapter work until you decide the scope, and leave the default/opt-in decision and version allocation to you. The compact-layout failure was real. I traced the overflow to the action control’s preferred width propagating into the composer, added shrink bounds and label elision, and kept the original failing assertion unchanged. Commit I have not exercised the adapter against a real Codex client on the phone. The fixtures do not establish real-client acceptance, and I will not present them as that. Your point about visibility and non-interactive approvals is valid: retaining the environment is not evidence of an interactive approval flow, so the README’s approval claim needs correction before acceptance. I will wait for your scope decision before changing the adapter or choosing between read-only execution and visible tool activity. The documentation URL currently resolves for me: https://developers.openai.com/codex/noninteractive redirects to https://learn.chatgpt.com/docs/non-interactive-mode. That page documents JSONL events and session resume; it does not replace the requested exact-version client run. I am handling the Search-specific theme/icon and dependency questions in #612. I will also remove committed review media in favour of PR attachments, and make the Quickshell CI/check dependency and retained non-empty session folders explicit in the description. No new adapter features are being added while the scope decision is pending. |
|
Thank you, @marselnenaj, for pausing as I asked, and for the plain answers. The compact-layout fix is right: the original assertion is untouched, the new case fails on the old code, and CI is green on this head. I also appreciate that you won't present the fixtures as a real-client run, and that you agree the README's approval sentence has to change. I've made the scope decision, and it's no to a vendor's adapter inside omamobile-shell. This is about what the shell should own, not about the quality of what you wrote:
What I would look at, if you want to take this further, is a different shape, and I'd ask for a short design issue before any code: the conversation view and the bridge's JSON-lines protocol in the shell with no vendor in them; adapters as separate drop-in files that the shell doesn't ship (a package of your own, or the user's); read-only as the default for this surface, the "runs with full permissions on this phone" line the voice bar already shows, and a visible trace of what the agent did; and a recorded run with the real client, with its version, before any adapter is accepted anywhere. Much of your bridge would carry over: explicit Send only, bounded output, a lock cancelling the request, plain-text replies. So please don't rebase this one. #612 is the PR to finish; I've left notes there on building its Back handling on today's main. I'll close this once #612 is settled, and the branch stays yours to draw from. |
|
Thanks for the scope decision. The part I wanted to contribute is the mobile flow: find the action from Search, compose and review a prompt comfortably, then send it explicitly. Could a smaller follow-up keep that UI and hand the prompt to the existing Omarchy agent route? The user's configured agent and the normal picker would work the same way as in Omarchy, and the terminal would show the agent's activity. This would use the existing If the in-shell conversation itself is worth pursuing separately, I can write the short design issue you requested first. It would cover a vendor-neutral bridge, separately installed adapters, read-only by default, clear permissions and visible activity, explicit Send and lock cancellation. I would qualify each adapter against a named real client version before proposing it. I'll leave #614 as it is and finish #612 first. |
|
Thank you, Marsel. Yes to the smaller follow-up, in its smallest form. The App Library already does the hand-over you describe: when the text reads like a sentence or matches no app, it offers "Ask " and Please open it as its own pull request once #612 is merged and has run on a phone, on top of main, with nothing from this branch's bridge or conversation view in it. For the in-shell conversation, the design issue first, as you offer. The list in your comment is the right one. I'll close this pull request when #612 is settled, as I said. The branch stays yours. |
Scope review pending: further adapter development is paused at the maintainer’s request. The CI layout correction is tracked separately below.
Add the phone's Ask Agent flow to native Search: tap the Ask card, edit the draft and Send, read replies, Stop a request or start a new conversation. Back returns to Search; Home/close dismiss it and cancel active work. The conversation stays in memory while the local bridge is idle.
The UI follows the configured default agent. This first native adapter supports an already installed Codex CLI; other agents receive an explicit terminal handoff through the existing Omarchy route. It reuses normal login/account configuration and explicitly requests the workspace-write sandbox. No client is installed. This non-interactive bridge has no approval UI; preserving the environment does not establish an interactive approval flow. Real-client acceptance and tool-activity visibility remain unresolved review requirements. This PR adds no microphone/login facade or personal configuration.
Request IDs, acknowledged cancellation/reset and exact owned thread identities prevent stale responses from reaching later requests. Completed context survives Stop and failed follow-ups. Account-home changes start fresh context. A stopped local bridge can recover through explicit re-entry or New chat. Generated task files remain in private session workspaces; only empty folders are removed at shutdown. Non-empty folders remain under
${XDG_STATE_HOME:-~/.local/state}/omamobile/agent-chat/; users may want to review and clear retained task files themselves.Depends on #612. Review the agent addition separately from the Search dependency: review only the addition. After #612 lands, this can be rebased onto main. The maintainer will allocate the package version at merge; the branch number is not reserved.
Interface
Actual rendered QML with genuine Omarchy modules, neutral themes and fictional app/conversation fixtures:
The recording uses 106 actual captures spanning 3.977 seconds, encoded losslessly with original intervals and no interpolated frames. Its reply events are inert fixtures rendered by the real controller and view. The 420 × 580 portrait previews show a reduced available viewport without drawing a keyboard. They do not measure phone, compositor blur, layer-shell focus or frame pacing.
Compact available viewport:
Validation
The full final package suite passes via
tests/packages omamobile-shell(398.85 seconds), including the actual UI/Python/inert-CLI integration. Final staging bytes and source pins match. Compact controls remain within the viewport even when platform button metrics prefer a wider size; a new regression exercises that case without weakening the original compact-layout check.CI now installs Quickshell to run the actual UI/bridge test rather than silently omitting it; it is also a check dependency. Staging includes the executable, its namespaced module and both new QML components. Exact-package phone acceptance for real account/client, touch keyboard, gestures and lock transitions remains outstanding. Existing fullscreen-strip and default-output limits from #612 remain.
Hosted checks for
d444ca7now pass, including the full package suite: GitHub Actions run. The previous head failed its compact-layout test; the unchanged test and additional preferred-width regression pass on this head.