Repository navigation
omamobile-modem-sit: explain the SMSC probe failure policy - #583
Merged
Merged
Conversation
Document why a failed or empty SMSC reply is incomplete with a present SIM, while the no-SIM error remains an expected result. Follow up on the review of derekross#569 without changing probe behavior or its package version. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Owner
|
Thank you, Marsel. That's the line I asked for, and it matches the code: an SMSC error fails the probe unless there is no SIM and the error is 11. On the version, since you raised it: One small wording note for whenever the function is next touched: an empty reply or a timeout also fails the probe when there is no SIM (only error 11 is excused there), and "with a present SIM" could be read as if they didn't. |
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…#583) Document why a failed or empty SMSC reply is incomplete with a present SIM, while the no-SIM error remains an expected result. Follow up on the review of derekross#569 without changing probe behavior or its package version. Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain why a failed or empty SMSC response leaves SMS configuration unverified when a SIM is present, while error 11 without a SIM remains expected. This is the docstring follow-up requested in #569.
The probe behavior and package version are unchanged. The eight real
probe()tests andtools/pr-checkpass.