Skip to content

omamobile-modem-sit: explain the SMSC probe failure policy - #583

Merged
derekross merged 1 commit into
derekross:mainfrom
marselnenaj:codex/sit-probe-smsc-doc
Nov 10, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
marselnenaj:codex/sit-probe-smsc-doc

Conversation

@marselnenaj

Copy link
Copy Markdown
Contributor

Explain why a failed or empty SMSC response leaves SMS configuration unverified when a SIM is present, while error 11 without a SIM remains expected. This is the docstring follow-up requested in #569.

The probe behavior and package version are unchanged. The eight real probe() tests and tools/pr-check pass.

Document why a failed or empty SMSC reply is incomplete with a present SIM,
while the no-SIM error remains an expected result. Follow up on the review
of derekross#569 without changing probe behavior or its package version.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, Marsel. That's the line I asked for, and it matches the code: an SMSC error fails the probe unless there is no SIM and the error is 11.

On the version, since you raised it: service.py is an installed file, so normally this would take a bump. 0.3.33 hasn't been published yet, though (the development repository still has 0.3.32), so merging now means its first build already has your docstring and no published version changes its contents. I'm merging it without a bump for that reason.

One small wording note for whenever the function is next touched: an empty reply or a timeout also fails the probe when there is no SIM (only error 11 is excused there), and "with a present SIM" could be read as if they didn't.

@derekross
derekross merged commit 10c48cc into derekross:main Nov 10, 2026
2 checks passed
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…#583)

Document why a failed or empty SMSC reply is incomplete with a present SIM,
while the no-SIM error remains an expected result. Follow up on the review
of derekross#569 without changing probe behavior or its package version.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants